Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVSS PCIU Migration: Step 6a: Remove PCIU references from pre-fill #76166

Open
4 of 11 tasks
Tracked by #73776
RachalCassity opened this issue Feb 14, 2024 · 7 comments
Open
4 of 11 tasks
Tracked by #73776

Comments

@RachalCassity
Copy link
Member

RachalCassity commented Feb 14, 2024

User Story

As a engineer on the VA.gov Platform, working on the PCIU deprecation, I want to remove PCIU, so that PCIU is completely removed from form prefill functionality

Issue Description

The EVSS PCIU service is being deprecated and removed from Vets API. PCIU references within the pre-fill logic need to be removed. This cleanup will streamline the pre-fill process and ensure the codebase reflects the current state of services.

Tasks

  • Ensure Feature Toggle in OFF for PCIU and ON for VA Profile Contact Information in prod
  • Remove PCIU from app/models/user.rb
  • Remove PCIU from app/models/form_profile.rb
  • Remove PCIU from spec/models/form_profile_spec.rb
  • Remove PCIU from spec/models/user_spec.rb
  • Remove PCIU from app/models/form_profiles/va_526ez.rb
  • Remove flipper references: remove_pciu, :va_v3_contact_information_service, :remove_pciu_2, disability_compensation_remove_pciu
  • Ensure tests are passing
  • Test locally
  • Test in staging

Acceptance Criteria

  • PCIU is removed from pre-fill logic
@jennb33 jennb33 added needs-grooming Use this to designate any issues that need grooming from the team 2024 PCIU labels Feb 14, 2024
@jennb33 jennb33 added Redis and removed needs-grooming Use this to designate any issues that need grooming from the team labels Mar 5, 2024
@jennb33
Copy link
Contributor

jennb33 commented Mar 20, 2024

Per @RachalCassity, she has been working with Seth Darr. PCIU calls have been removed and implementation has been held up. Disability Benefits team is focused on the the 526 form, and it doesn't appear that we are overlapping.

@RachalCassity
Copy link
Member Author

RachalCassity commented Mar 20, 2024

@jennb33 Moving this back to the Upcoming Sprint. Waiting for Disability team to update all PCIU. This service is still being used, datadog pciu metrics.

@RachalCassity RachalCassity changed the title Remove REDIS pciu_address_dependencies file and references EVSS PCIU Migration: Objective 6: Remove REDIS pciu_address_dependencies file and references Mar 21, 2024
@jennb33 jennb33 changed the title EVSS PCIU Migration: Objective 6: Remove REDIS pciu_address_dependencies file and references EVSS PCIU Migration: Step 6: Remove REDIS pciu_address_dependencies file and references Mar 26, 2024
@jennb33 jennb33 removed the blocked label Apr 18, 2024
@jennb33 jennb33 assigned rmtolmach and unassigned rjohnson2011 Sep 10, 2024
@jennb33 jennb33 changed the title EVSS PCIU Migration: Step 6: Remove REDIS pciu_address_dependencies file and references EVSS PCIU Migration: Step 5: Remove REDIS pciu_address_dependencies file and references Sep 23, 2024
@jennb33 jennb33 assigned rjohnson2011 and unassigned rmtolmach Sep 24, 2024
@jennb33 jennb33 assigned RachalCassity and unassigned rjohnson2011 Oct 7, 2024
@AshleyGuerrant
Copy link

Moving out 2 sprints. This work should happen after ContactInformation is complete. ContactInformation is replacing PCIU, these tickets cannot be worked on until ContactInformation has been done and the PCIU has been replaced.

@RachalCassity RachalCassity changed the title EVSS PCIU Migration: Step 5: Remove REDIS pciu_address_dependencies file and references EVSS PCIU Migration: Final Step: Remove REDIS pciu_address_dependencies file and references Dec 5, 2024
@RachalCassity
Copy link
Member Author

Contact Information V2 has to replace PCIU in prod before PCIU references can be removed.

@AshleyGuerrant AshleyGuerrant changed the title EVSS PCIU Migration: Final Step: Remove REDIS pciu_address_dependencies file and references EVSS PCIU Migration: Final Step (a): Remove REDIS pciu_address_dependencies file and references Dec 11, 2024
@AshleyGuerrant AshleyGuerrant changed the title EVSS PCIU Migration: Final Step (a): Remove REDIS pciu_address_dependencies file and references EVSS PCIU Migration: Step 6 (a): Remove REDIS pciu_address_dependencies file and references Dec 11, 2024
@AshleyGuerrant AshleyGuerrant changed the title EVSS PCIU Migration: Step 6 (a): Remove REDIS pciu_address_dependencies file and references EVSS PCIU Migration: Step 6a: Remove REDIS pciu_address_dependencies file and references Dec 12, 2024
@AshleyGuerrant
Copy link

@RachalCassity - thanks for the additional context as to why this ticket is blocked.

Contact Information V2 has to replace PCIU in prod before PCIU references can be removed.

What specific ticket numbers(s) are tracking the work mentioned above & are blocking this this work?

@AshleyGuerrant AshleyGuerrant added the needs-refinement Identifies tickets that need to be refined label Dec 16, 2024
@RachalCassity RachalCassity changed the title EVSS PCIU Migration: Step 6a: Remove REDIS pciu_address_dependencies file and references EVSS PCIU Migration: Step 6 (a): Remove PCIU references from pre-fill Dec 17, 2024
@AshleyGuerrant
Copy link

This work is blocked by Step 4c.

@AshleyGuerrant AshleyGuerrant removed the needs-refinement Identifies tickets that need to be refined label Dec 18, 2024
@AshleyGuerrant AshleyGuerrant changed the title EVSS PCIU Migration: Step 6 (a): Remove PCIU references from pre-fill EVSS PCIU Migration: Step 6a: Remove PCIU references from pre-fill Dec 18, 2024
@RachalCassity
Copy link
Member Author

@AshleyGuerrant Started working on this on 12/26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants