Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design | Figma migration | Update VA design system components once fixed #72085

Closed
8 tasks done
Tracked by #71836
andaleliz opened this issue Dec 15, 2023 · 7 comments
Closed
8 tasks done
Tracked by #71836
Assignees
Labels
authenticated-experience VA.gov authenticated experience design profile

Comments

@andaleliz
Copy link
Contributor

andaleliz commented Dec 15, 2023

Background

When migrating Sketch files to Figma, we noticed some components in the design system had a bug. The buggy components have our content in place and are placed next to the appropriate frame, ready to move in once the DST applies their fixes.

We need to update our Figma files once those fixes are in place. Since the fix tickets are in a different repo, we can't add them as blockers through Zenhub, but we can track them here:

Components

Tasks

Update the library/components in the following files:

  • Connected apps
  • Personal info
  • Contact info
  • Notification settings
  • Direct deposit
  • Account security
  • Profile hub
  • Military information

AC

  • Figma files align to what we see in storybook for the available components.
@andaleliz andaleliz added design authenticated-experience VA.gov authenticated experience profile labels Dec 15, 2023
@andaleliz andaleliz changed the title Design | Figma migration | Update design system components once fixed Design | Figma migration | Update VA design system components once fixed Dec 26, 2023
@mattmarino-adhoc mattmarino-adhoc removed their assignment Feb 8, 2024
@andaleliz
Copy link
Contributor Author

@mtcA6 fyi I am going to pick this up and start working on it.

@andaleliz
Copy link
Contributor Author

andaleliz commented Apr 15, 2024

While going through this, I checked on the guidance for addresses from the design system. They've updated it and there are changes to our form as a result. I've mocked them up and annotated them on a separate page, and I think this should probably have a dedicated FE ticket as a result @mtcA6 @adamwhitlock1

The prod pages in the Figma file reflect the current state; I will move the mock-ups from the new page into the prod pages once they're live.

@andaleliz
Copy link
Contributor Author

All of the files are updated, but I can't close this out yet due to an outstanding bug w/ the modal buttons in personal information and the editing as a subtask page. I've reached out to the DS and I'm going to give them a day or two to respond. If they don't, I think I'll still close this ticket out as it's pretty minor and I can leave a comment to explain to anyone who peeks at the files what is going on.

@andaleliz
Copy link
Contributor Author

They still haven't gotten back to me - going to leave this open until the end of the sprint but will close Tuesday if I don't hear by then.

@mtcA6
Copy link
Contributor

mtcA6 commented Apr 19, 2024

@andaleliz great approach.

Do we need to spin up another ticket to toss in the backlog and we can come back to that in a few weeks?

@andaleliz
Copy link
Contributor Author

@mtcA6 nah, I don't think so - I have a feeling it'll be a 2 minute fix once they respond to me. I set a reminder on my message to them to reach back out to them before the end of the sprint, and if it happens after the fact it'll probably take more time to create/monitor tickets than to just implement whatever fix they propose.

@andaleliz
Copy link
Contributor Author

Dan got back to me today and helped me troubleshoot. We're all good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authenticated-experience VA.gov authenticated experience design profile
Projects
None yet
Development

No branches or pull requests

4 participants