Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facility locator detail pages: columns don't fit side by side at desktop breakpoint #20133

Open
1 task
jilladams opened this issue Dec 18, 2024 · 2 comments
Open
1 task

Facility locator detail pages: columns don't fit side by side at desktop breakpoint #20133

jilladams opened this issue Dec 18, 2024 · 2 comments
Assignees
@randimays
Labels
Facilities Facilities products (VAMC, Vet Center, etc) Facility Locator detail page A page used in facility locator for non-modernized facility types Needs refining Issue status sitewide VA.gov frontend CMS team practice area

Comments

@jilladams
Copy link
Contributor

Description

Potentially a regression due to DST changes to use USWDS stylesheets more broadly, not sure.

To repro:

Image

Engineering notes / background

It looks like the definitions for .usa-width-one-third and .usa-width-two-thirds rules don't play nicely to fit side by side at this breakpoint anymore. Might be due to some padding or something. Switching to .medium-7 on the left allows them to sit side by side, as does adjusting the width of the one-third rule.

Acceptance criteria

  • Left and right columns sit side by side at desktop breakpoint on Facility locator detail pages
@jilladams jilladams added Needs refining Issue status sitewide VA.gov frontend CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Facility Locator detail page A page used in facility locator for non-modernized facility types labels Dec 18, 2024
@jilladams
Copy link
Contributor Author

@randimays if you are blocked on the AP ticket, this one might be a quickie to look into, potentially.

@randimays randimays self-assigned this Dec 20, 2024
@randimays
Copy link
Contributor

Pulled in for Sprint 19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@randimays randimays

Labels
Facilities Facilities products (VAMC, Vet Center, etc) Facility Locator detail page A page used in facility locator for non-modernized facility types Needs refining Issue status sitewide VA.gov frontend CMS team practice area
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@randimays @jilladams