-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Analytics] Audit PW GA spreadsheet and create additional tickets #18421
Comments
Facilities ticket where analytics were gathered: #17532 |
End of sprint update: I have created some tickets for Public Websites, but no tickets have been created for Facilities yet (and I'm not sure of the lift; I haven't had time to review the spreadsheets in this ticket). I want to do another pass through all of the custom events for Public Websites and make sure I've captured everything and that the spreadsheet is totally up-to-date. After that, I'm going to move over to Facilities and do that same for those products. This will certainly carry over. I estimate there's probably about 3 points of effort left. Noting that the original points for this did not include Facilities work. |
Noting from sprint planning: we had to pause this work for Injected header, and have had enough other priority work pop up that it wasn't possible prioritize in Sprint 8. Unassigning Randi, moving back to Ready, and when we are able to pick this up again, we will. |
@FranECross @Agile6MSkinner Re: analytics for VBA pages I ask specifically about these because this code is relatively new and is already using web components so I'm not sure if the custom events are intentionally duplicative. Example page: https://web-cmugn5ieupsmz1cyrrmcwiwcawfidlrx.demo.cms.va.gov/philadelphia-va-regional-benefit-office/ The phone numbers in the first screen and the "Find a VA benefits location" link in the second screenshot are currently using web components, but they also have custom events on them (meaning we are getting two events for each one). For Main Phone, we are sending a custom event with this info:
A For VA benefits hotline, we are sending a custom event with this info:
Same as above; this is a For Find a VA benefits location, we are sending a custom event with this info:
This is a |
@FranECross @Agile6MSkinner I found a few more VBA links that I'll need some help clarifying whether they need action: https://web-2pegzvqcy77ynmcultaityqtlrpfbfoo.demo.cms.va.gov/honolulu-va-regional-benefit-office-at-spark-m-matsunaga-department-of-veterans-affairs-medical-center/ > Disability compensation accordion, Learn how to manage disability compensation benefits online link: This link has already been converted to a web component but it has a duplicate link on it. Custom event:
Schedule an appointment online link (I couldn't find a Tugboat URL / VBA facility to test this on). This link is not a web component; should it be converted and use baked-in analytics? Custom event:
Email address link (I couldn't find a Tugboat URL / VBA facility to test this on). This link is not a web component; should it be converted and use baked-in analytics? Custom event:
CC @laflannery Do you know of a Tugboat link where I could find the Schedule an appointment online and Email address links? |
@randimays The schedule an appoint link should be in Disability compensation and pretty much every service accordion in Honolulu. I think one of the VBA tickets we did recently somehow messed this up and it's not showing now. I'm going to investigate and see what I can find. Regarding the email addresses, those just recently got fixed I believe but we don't have a ton of actual services. I can add some and release content on my own tugboat shortly for this |
@randimays I'll need to defer to @Agile6MSkinner regarding the VBA analytics/links. |
@randimays @laflannery If we have the tracking in the web components, it seems like the custom events would be redundant, no? It seems like there's a bigger picture here that I'm not getting in terms of the move to GA4 and what analytics are now in web components vs what we need custom events for. Who can bring me up to speed on that? |
@aklausmeier Tagging in Amanda, since she has insight into what some of our custom events gather. @Agile6MSkinner For some background, the events that the components are providing are extremely basic, and in some cases don't give enough information depending on the feature. For instance, the analytics person (Jamie) reviewed our custom events recently, and as an example said for the Campaign Landing pages she thought we should keep them and not use the baked in component analytics because we lose all the section/location information by doing adopting the component analytics (she recommends going back to the clp-link-click event if that was important). In many cases, we can go ahead and implement the component, but then just disable the baked in analytics and continue to use the custom analytics. cc @randimays @laflannery @mmiddaugh |
We don't want duplicate events being sent through GA4. There is a cost associated but we also don't want to compromise on losing data. If there is no risk of losing data and it's a duplicate then that seems to suggest the baked in DST component is sufficient and custom can go away. If there is a grey area or you are unsure, I strongly suggest reaching out to the analytics team in their Slack to confirm. |
@FranECross We already removed all the custom events in Campaign Landing Pages (this ticket's ACs said to remove all custom events and fall back to baked-in). Didn't we say that section (location on the page) was unnecessary since we have the text of the link and the origin URL? |
Here is a tugboat with both the Schedule and appointment and email links for you to take a look at: Philadelphia VBA Life Insurance Service https://web-codylbelkq0gdivw6x7tykigmeqloewe.demo.cms.va.gov/philadelphia-va-regional-benefit-office/vba-service-item-1147- |
@randimays Thanks for the reminder, and you're absolutely correct. We did decide the baked-in analytics would suffice for this one. I think I was confusing it with a different convo I'd had. Thanks. |
@FranECross @Agile6MSkinner This audit is complete and we have an additional 25 tickets in this epic: #18184. I'm closing this ticket. Background for web component vs. custom GA events and the analytics migrationThe Platform Analytics team (Slack channel: In the front end repos ( A design system web component (such as It is also possible to use both web component analytics and a custom event together. ℹ️ For the purposes of this epic / audit, we are only concerned with removing custom events where the custom event can be replaced by the web component baked-in event. We are not adding new events or updating existing events otherwise. Updated Sitewide Google Analytics events spreadsheethttps://docs.google.com/spreadsheets/d/1fDsRQct_QMJ5nd3bTRDgwrfbFo_PqzdFQqYecJouic8/edit?gid=0#gid=0 Events tabA comprehensive list of GA events, both current/future and events that have already been removed as of 7/17/2024. Columns explanationCustom event to be removed
Custom event is on top of web comp event
Sitewide FE pages / Example URL: Sitewide product and example URL where this interaction can be found (or API call is made)Ticket status
Elements with custom events, event name, other event dataSpecifics for what element triggers the event, the event name in GA, and any other data that is logged. Web Component Analytics tabA list of web components' baked-in analytics from the Design System team. This is not a comprehensive list of all web components used by Sitewide products; these are the web components that Sitewide products used that had custom GA events at the time we started doing this audit. |
Description
Our custom GA events epic (#18184) does not accurately represent the work required from the spreadsheet. There was also at least one missing item on the spreadsheet (for homepage hub links).
See this Slack thread for context: https://dsva.slack.com/archives/C52CL1PKQ/p1719507165841209
Acceptance criteria
The text was updated successfully, but these errors were encountered: