Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Aging Content] Implement text for Developer Configuration Drupal fields #18019

Closed
6 tasks
Tracked by #17975 ...
FranECross opened this issue May 1, 2024 · 3 comments
Closed
6 tasks
Tracked by #17975 ...
Assignees
Labels
Aging Content Notifications Aging Content notifications & archiving Drupal engineering CMS team practice area Public Websites Scrum team in the Sitewide crew sitewide Sprint 6

Comments

@FranECross
Copy link

FranECross commented May 1, 2024

Description

The new developer-facing Drupal fields created as part of the Aging Content Notifications work should have descriptive field text that will aid the developer in their understanding of what to do.

Glossary

  • Entity = Content
  • Bundle - Description

User story

AS A Drupal developer who is configuring aging content expiration and notifications for one or more content types (banner, block, etc.)
I WANT descriptive labels on the various fields in the UI that I'll utilize
SO THAT I can easily and quickly configure the aging content expiration and notification emails

Engineering notes / background

Analytics considerations

Quality / testing notes

Acceptance criteria

  • 'Expirable Content types' screen:
    • Entity type: Text = Select the entity type to add content that can expire.
    • Entity bundle: Text = Select the bundle of the entity type.
    • Last updated field: Text = Select the name of the field that will calculate when the entity was last updated.
    • Days before expiration: Text = Enter the number of days before the entity will expire. This will be the number of days after the entity was created or last updated.
    • Days to notify before expiration: Text = Enter the number of days to notify an editor before an entity expires.

Artifacts

  1. Ticket for Drupal work: [Aging Content - Banner] Drupal: Implement Full Width Banner Aging Content Notification Emails MVP #15506

  2. Expirable Content types fields

image-1

  1. Structure fields

image

@FranECross FranECross added Needs refining Issue status Public Websites Scrum team in the Sitewide crew Drupal engineering CMS team practice area labels May 1, 2024
@FranECross FranECross changed the title [Aging Content] Implement for Aging Content Developer Configuration Drupal fields [Aging Content] Implement text for Developer Configuration Drupal fields May 1, 2024
@FranECross FranECross added the Aging Content Notifications Aging Content notifications & archiving label May 9, 2024
@FranECross FranECross removed the Needs refining Issue status label May 21, 2024
@dsasser
Copy link
Contributor

dsasser commented Jun 18, 2024

Status Update 6/18/24

** Blocked on #18005 **
Since #18005 is also updating Expirable Content, we'll need to wait for that to merge before we can proceed with this work.

The code for the text changes has been committed to the Expirable Content module. In order to realize the update in the CMS, we'll need to:

  1. Wait for [Aging Content] Write unit tests for the notifications framework (& full-width alert/banner if applicable) #18005 to merge
  2. Cut a new Expirable Content release
  3. Update Expirable Content to the new version in the CMS repo.

@dsasser
Copy link
Contributor

dsasser commented Jul 8, 2024

This PR is in but it is failing cypress tests which I'm now looking into.

@dsasser
Copy link
Contributor

dsasser commented Jul 9, 2024

End of Sprint Update 7/9/24

PR is in and awaiting review. Since Christian is out, I reached out to other CMS engineers for review assistance.

This work has been completed and verified in prod:

Screenshot 2024-07-09 at 10 58 38 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aging Content Notifications Aging Content notifications & archiving Drupal engineering CMS team practice area Public Websites Scrum team in the Sitewide crew sitewide Sprint 6
Projects
None yet
Development

No branches or pull requests

3 participants