Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Facility Locator fields to be the same height #17836

Closed
3 tasks
thejordanwood opened this issue Apr 12, 2024 · 4 comments
Closed
3 tasks

Update Facility Locator fields to be the same height #17836

thejordanwood opened this issue Apr 12, 2024 · 4 comments
Labels
Facilities Facilities products (VAMC, Vet Center, etc) Facility Locator product owned by Facilities team Needs refining Issue status sitewide UX VA.gov frontend CMS team practice area

Comments

@thejordanwood
Copy link

thejordanwood commented Apr 12, 2024

Description

When the Facility Locator template was update to v3 components in #17071 , the Facility type field became smaller than the Service type and location fields.

The Facility type field is now 2 px shorter. Consider adjusting the height of the Service type field to be the same as the Facility type field.

Screenshot 2024-04-11 at 2 47 00 PM

Additional update

The label on the Facility type field should use sentence case and be "Facility type" instead of "Facility Type"

Acceptance criteria

Preview Give feedback

QA

Preview Give feedback
@Agile6MSkinner
Copy link

@thejordanwood to check if it's still an issue. If it is, we can re-open it if we have the capacity and it becomes a priority.

@thejordanwood
Copy link
Author

@Agile6MSkinner I was really hoping the typography update would fix this, but I don't think it did. This is still an issue, fyi.

@Agile6MSkinner
Copy link

@thejordanwood - Per @laflannery this may be resolved as part of componentizing the search filters in other work. Is that accurate? @davidmpickett Perhaps we can touch on this in next UX sync.

@thejordanwood
Copy link
Author

@Agile6MSkinner Yes, this should be resolved when these are turned into components. I'll close this ticket and add that note to the facility locator design update ticket that I have open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc) Facility Locator product owned by Facilities team Needs refining Issue status sitewide UX VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

3 participants