Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE Re-usable Q&A] Change the cardinality in the config for re-usable Q&As for CLPs #17805

Closed
2 tasks done
Tracked by #17772
FranECross opened this issue Apr 10, 2024 · 8 comments
Closed
2 tasks done
Tracked by #17772
Assignees
Labels
Drupal engineering CMS team practice area Public Websites Scrum team in the Sitewide crew

Comments

@FranECross
Copy link

FranECross commented Apr 10, 2024

Description

In support of this ticket > CLP: FE combine page-specific and reusable Q&As under the same header & accordion group #10940, the cardinality of the re-usable Q&A field on CLPs (only) needs to be changed to 1 via the config.

User story

AS THE engineer working on the ticket referenced above
I WANT the changes described above and in the AC to be made in support of the ticket I'm working on
SO THAT I can successfully complete the work to limit re-usable Q&As to 2 on CLPs, which will provide a better experience for Veterans, their caregivers, family and survivors

Engineering notes / background

Analytics considerations

Quality / testing notes

Acceptance criteria

  • the cardinality of the re-usable q&a field on CLPs has been changed to 1 via the config
  • Verified the shape of the GraphQL data didn't change (which would affect Randi's work). the shape DID change
@FranECross FranECross added Drupal engineering CMS team practice area Needs refining Issue status Public Websites Scrum team in the Sitewide crew labels Apr 10, 2024
@FranECross
Copy link
Author

@dsasser Here's the ticket in support of Randi's re-usable Q&A ticket. I put it in Ready for you to pull in, if you're able to (if it won't blow up the work you're currently trying to get done). Or, alternatively, it can be pulled in next week in the new sprint. cc @jilladams @randimays

@jilladams
Copy link
Contributor

jilladams commented Apr 10, 2024

@FranECross Based on mid-sprint checkin, this won't naturally fit in sprint, but there might be a product argument to make for prioritizing it above other things at risk in sprint after the notifications work. If you make a call on that, just surface for Dave and cc me.

@dsasser
Copy link
Contributor

dsasser commented Apr 24, 2024

Mid-sprint Update 4/24/24

I plan to get this done in the morning. It is a quick change requires context switching I haven't been ready to do until now.

@dsasser
Copy link
Contributor

dsasser commented Apr 27, 2024

@FranECross @randimays @jilladams
I verified that after making the cardinality change, the graphql output does change the data type from an array of objects to a single object:

Screenshot 2024-04-27 at 9 01 28 AM Screenshot 2024-04-27 at 9 06 18 AM

@dsasser
Copy link
Contributor

dsasser commented Apr 30, 2024

End of Sprint Update 4/30/24

PR is in review. Prior to merge we'll need to verify if changes are needed first on the FE in order to accommodate the data shape of the graphql changing.

@jilladams
Copy link
Contributor

@dsasser When PR merges, will you move this ticket to "Complete Pending Integration"?

@dsasser
Copy link
Contributor

dsasser commented Apr 30, 2024

@dsasser When PR merges, will you move this ticket to "Complete Pending Integration"?

Done.

@dsasser
Copy link
Contributor

dsasser commented May 2, 2024

Verified in prod:
Screenshot 2024-05-02 at 7 49 42 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Drupal engineering CMS team practice area Public Websites Scrum team in the Sitewide crew
Projects
None yet
Development

No branches or pull requests

3 participants