Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit uses of font-awesome for va-icon replacement #17737

Closed
7 tasks done
jilladams opened this issue Apr 4, 2024 · 10 comments
Closed
7 tasks done

Audit uses of font-awesome for va-icon replacement #17737

jilladams opened this issue Apr 4, 2024 · 10 comments
Assignees
Labels
CY24-Q2 Calendar year Q2 2024 priority Facilities Facilities products (VAMC, Vet Center, etc) sitewide VA.gov frontend CMS team practice area va-icon

Comments

@jilladams
Copy link
Contributor

jilladams commented Apr 4, 2024

Goal: va-icon adoption (Design System Team Initiative for all teams):

Font Awesome will be deprecated. The DST is working on guidance for how teams can migrate onto va-icon. They tentatively expect Font Awesome to be deprecated at the end of May 2024

We need to audit usage in the facilities product, to understand scope of getting these changed.

DS guidance (WIP): https://design.va.gov/storybook/?path=/docs/uswds-va-icon--default

Scope & Notes

Probably in both content-build and vets-website?

All font-awesome icons appear in <i> tags. They're everywhere.

Correlated Public Websites work, for reference: (Randi = POC)

ACs

  • Facilities products are audited for font-awesome use, and
    • VAMC (systems, facilities, top task pages)
    • Vet Centers
    • Facility Locator
    • Facility Locator detail pages
    • Regional Offices (pre-prod templates)
  • tickets are cut for FE work to update products in whatever way makes sense to FE folks
  • Schedule calendar time with Jill, Michelle (required) and DaveP (optional) to review audit findings, and determine priority for Sprint 2 injection vs. Sprint 3
@jilladams jilladams added Facilities Facilities products (VAMC, Vet Center, etc) VA.gov frontend CMS team practice area Needs refining Issue status labels Apr 4, 2024
@jilladams
Copy link
Contributor Author

Facility Locator detail pages are generated from the API, but we don't think we've touched them.
Contained under the Facility Locator app, per Eli.

@laflannery to take a look re: V3 components to make sure we haven't overlooked components on those.

@jilladams
Copy link
Contributor Author

Eli: would be ok with one ticket to replace font-awesome usage across all our products in both repos.
But: bigger testing burden.
3 for content-build, 3 for vets-website maybe for implementation, tbd DS guidance / how many invocations
The replacement params will affect scope: may include style changes, will depend on what the va-icon spec is.

@jilladams jilladams removed the Needs refining Issue status label Apr 10, 2024
@jilladams
Copy link
Contributor Author

Mapping from Font-awesome sizes (S, M, L), to DS component (3-9) may be a sizable piece of the work.

@davidmpickett davidmpickett added the CY24-Q2 Calendar year Q2 2024 priority label Apr 11, 2024
@jilladams jilladams changed the title Audit uses of font-awesome for icon replacement Audit uses of font-awesome for va-icon replacement Apr 15, 2024
@eselkin
Copy link
Contributor

eselkin commented Apr 15, 2024

It seems that only a few places in the current font awesome inclusions use sizes. Those are not any of our Facilities products.

@davidmpickett
Copy link
Contributor

@jilladams Do you want to tag this with Sprint 1 since it technically started before Sprint 2? Or just do Sprint 2 since it wasn't part of Sprint 1 commitment? Not sure what your preference for reporting is

@jilladams
Copy link
Contributor Author

Thanks Dave - Added sprint 1

@eselkin
Copy link
Contributor

eselkin commented Apr 16, 2024

Tickets created:
VAMC content-build and vets-website in one ticket: #17855
Vet Center and Vet center Locations in one ticket: #17874
Facility Locator and Detail Pages in one ticket: #17884
VBA: #17886

@eselkin
Copy link
Contributor

eselkin commented Apr 17, 2024

@jilladams All tickets created

@davidmpickett
Copy link
Contributor

Added all tickets to the epic: #17722

@jilladams
Copy link
Contributor Author

Laura, Michelle, Eli and I reviewed. @laflannery to handle one cleanup piece where va-link component adoption needs to be handled within these icon tickets.

Otherwise: tickets are mostly refined, remaining cleanups on refining are added to team refinement ticket, and we've kicked off a conversation with the DS around what happens next. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CY24-Q2 Calendar year Q2 2024 priority Facilities Facilities products (VAMC, Vet Center, etc) sitewide VA.gov frontend CMS team practice area va-icon
Projects
None yet
Development

No branches or pull requests

3 participants