-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit uses of font-awesome for va-icon replacement #17737
Comments
Facility Locator detail pages are generated from the API, but we don't think we've touched them. @laflannery to take a look re: V3 components to make sure we haven't overlooked components on those. |
Eli: would be ok with one ticket to replace font-awesome usage across all our products in both repos. |
Mapping from Font-awesome sizes (S, M, L), to DS component (3-9) may be a sizable piece of the work. |
It seems that only a few places in the current font awesome inclusions use sizes. Those are not any of our Facilities products. |
@jilladams Do you want to tag this with Sprint 1 since it technically started before Sprint 2? Or just do Sprint 2 since it wasn't part of Sprint 1 commitment? Not sure what your preference for reporting is |
Thanks Dave - Added sprint 1 |
@jilladams All tickets created |
Added all tickets to the epic: #17722 |
Laura, Michelle, Eli and I reviewed. @laflannery to handle one cleanup piece where va-link component adoption needs to be handled within these icon tickets. Otherwise: tickets are mostly refined, remaining cleanups on refining are added to team refinement ticket, and we've kicked off a conversation with the DS around what happens next. Closing! |
Goal: va-icon adoption (Design System Team Initiative for all teams):
Font Awesome will be deprecated. The DST is working on guidance for how teams can migrate onto va-icon. They tentatively expect Font Awesome to be deprecated at the end of May 2024
We need to audit usage in the facilities product, to understand scope of getting these changed.
DS guidance (WIP): https://design.va.gov/storybook/?path=/docs/uswds-va-icon--default
Scope & Notes
Probably in both content-build and vets-website?
All font-awesome icons appear in
<i>
tags. They're everywhere.Correlated Public Websites work, for reference: (Randi = POC)
ACs
The text was updated successfully, but these errors were encountered: