Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAMC Health Services template: adopt V1 & v3 components (incl spotlights) where components aren't used #17657

Closed
7 of 9 tasks
jilladams opened this issue Mar 27, 2024 · 5 comments
Assignees
Labels
accessibility Issues related to accessibility CY24-Q2 Calendar year Q2 2024 priority Facilities Facilities products (VAMC, Vet Center, etc) Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area VAMC CMS managed product owned by Facilities team

Comments

@jilladams
Copy link
Contributor

jilladams commented Mar 27, 2024

Description

#16997 tracked adopting existing V3 components

VAMC Health Service pages need the following updates to components:

Example pages:

Elements that are not using components that should be

  1. Link
    • Links are not using a component but should be using the v1 component if possible, with the understanding that CMS content has limitations
  2. Telephone
    • The component should be used if possible, with the understanding that CMS content has limitations
    • Exts in phone numbers should be parsed correctly
  3. Back to top
  4. Spotlights

Screenshot 2024-03-22 at 12 04 32 PM

Acceptance Criteria

  • Link component has been added
  • Back to top component has been added, if applicable
  • Card component, with correct markup has been added to Spotlights
  • Update and run existing test(s).
  • If additional tests are needed, stub a ticket to note this for future work.
  • Requires accessibility review
  • When PR is ready to merge, @jilladams for change management trigger
  • Change management for Spotlight update
  • Backport findings re: Spotlight grid to Adopt spotlight-card class on spotlight cards on Vet Centers and VBA #18126
@jilladams jilladams added Public Websites Scrum team in the Sitewide crew VAMC CMS managed product owned by Facilities team VA.gov frontend CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) and removed Public Websites Scrum team in the Sitewide crew labels Mar 27, 2024
@jilladams jilladams added the accessibility Issues related to accessibility label Mar 27, 2024
@laflannery
Copy link
Contributor

I added an AC for change management for the spotlight section - I spoke to @mmiddaugh and since there is a large-ish display chang she felt that giving folks a heads up that this was happening would be good.

@laflannery
Copy link
Contributor

Telephone moved to #16148

@jilladams jilladams changed the title VAMC Health Services template: adopt V1 & v3 components where components aren't used VAMC Health Services template: adopt V1 & v3 components (incl spotlights) where components aren't used Apr 11, 2024
@davidmpickett davidmpickett added the CY24-Q2 Calendar year Q2 2024 priority label Apr 11, 2024
@laflannery laflannery added the Public Websites Scrum team in the Sitewide crew label May 15, 2024
@jilladams
Copy link
Contributor Author

jilladams commented May 15, 2024

We don't want naked link but we do have to put up guardrails when editors inevitably put them in
To achieve that: create the Spotlight section in a way that they'll all have an equal width if an editor adds a naked links when there are multiple spotlights. (#18126 offers a potential solution.)

@laflannery
Copy link
Contributor

@jilladams - updated your comment above with just some more specific context

@randimays
Copy link
Contributor

I saw the change management discussion in Slack here: https://dsva.slack.com/archives/C06NMUK12LR/p1716323803156549. Please let me know if there are any other things we need to do from an engineering perspective.

The code has been merged to production and validated successfully. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issues related to accessibility CY24-Q2 Calendar year Q2 2024 priority Facilities Facilities products (VAMC, Vet Center, etc) Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area VAMC CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

5 participants