Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update label for mental health phone number in service accordions #17373

Open
mmiddaugh opened this issue Feb 28, 2024 · 8 comments
Open

Update label for mental health phone number in service accordions #17373

mmiddaugh opened this issue Feb 28, 2024 · 8 comments
Labels
Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status sitewide VA.gov frontend CMS team practice area VAMC CMS managed product owned by Facilities team

Comments

@mmiddaugh
Copy link
Contributor

mmiddaugh commented Feb 28, 2024

Description

This issue will update the label for Mental health phone numbers to follow this pattern.

Screenshots image.png image.png

Tasks

  • for the number which references the CMS Mental health phone number and appears in VAMC Mental health service accordions, update the label from Main phone to Mental health phone

Acceptance criteria

  • The mental health phone number appearing in VAMC Mental health service accordions uses a label consistent with other displays of the number
  • Labels for other phone numbers (entered by local staff) appearing in the VAMC Mental health service accordion are not changed
  • Labels for phone numbers in other health services are not changed
  • Tests are updated or added as needed
@mmiddaugh mmiddaugh added the Facilities Facilities products (VAMC, Vet Center, etc) label Feb 28, 2024
@mmiddaugh mmiddaugh changed the title Update label for mental health phone number is service accordions Update label for mental health phone number in service accordions Feb 28, 2024
@mmiddaugh mmiddaugh added VA.gov frontend CMS team practice area VAMC CMS managed product owned by Facilities team Needs refining Issue status labels Feb 28, 2024
@laflannery
Copy link
Contributor

@mmiddaugh This is still outstanding correct? If that's the case we should probably update this when we do the FE work for the new phone number fields here. @Agile6MSkinner I believe the only additional work that would need to be added to that ticket (which is in the current sprint) is to confirm the proper label for the field and then update any instances that might not be using that

@Agile6MSkinner
Copy link

@SnowboardTechie what do you think about pulling this in to that story per Michelle's comment above?

@SnowboardTechie
Copy link

@Agile6MSkinner looking this over and I totally agree with @laflannery that this overlaps the other phone number fields work I have in queue. I'm going to assign this to myself now.

@jilladams
Copy link
Contributor

This ticket is about labeling on an existing phone number paragraph field, so does make sense to try and address it as a fast follow to the phone number migration work. Added to epic.

@SnowboardTechie
Copy link

With the work in #17867 very closely overlapping and updating the phone numbers appearing in VAMC Mental health service accordion, we have added this label work to that ticket.

@laflannery
Copy link
Contributor

@jilladams and @Agile6MSkinner After doing all the work/QA for the phone number migration, @eselkin and I realized that updating labels within the service locations would be outside the scope of the migration tickets - it does not touch the same pieces of code. We feel that it would be better to re-open this ticket and leave it for a later time.

@laflannery laflannery reopened this Oct 28, 2024
@jilladams
Copy link
Contributor

We need to figure out where to put this ticket, since it's not going to close as a part of the #17854 epic.

@jilladams
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status sitewide VA.gov frontend CMS team practice area VAMC CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

5 participants