Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BLOCKED] Update Download PDF link on Form detail pages to <button> element #17314

Open
1 task
laflannery opened this issue Feb 22, 2024 · 2 comments
Open
1 task
Labels
accessibility Issues related to accessibility Blocked Issues that are blocked on factors other than blocking issues. Needs refining Issue status Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area

Comments

@laflannery
Copy link
Contributor

laflannery commented Feb 22, 2024

Status

[2024-08-19] [Fran] Blocked by the linked Spike.

Description

We recently removed the find_forms_show_pdf_modal flipper so that now we always show the modal when the user clicks to Download the PDF on the Find forms search results. When this was done, the element for "Download PDF" was switched to a <button> because it now activates the modal consistently.

Screenshot 2024-02-22 at 7 58 25 PM
Screenshot 2024-02-22 at 7 58 52 PM

This element is also present on the forms detail page but is currently still an <a> tag. For consistency should also change this to the same <button> behavior as on the search results:
image

Acceptance Criteria

  • When a user clicks to Download the PDF The Forms Detail page, the same behavior as on the search results occurs.
@laflannery laflannery added Needs refining Issue status VA.gov frontend CMS team practice area Public Websites Scrum team in the Sitewide crew labels Feb 22, 2024
@FranECross
Copy link

Fran to create Spike ticket to refresh our memories on what's happening. Daniel might have some background on this.

@FranECross FranECross added Blocked Issues that are blocked on factors other than blocking issues. Product management and removed Blocked Issues that are blocked on factors other than blocking issues. labels Mar 20, 2024
@laflannery
Copy link
Contributor Author

There is an epic specifically to get the listing and detail behavior of this modal experience the same, this ticket would probably belong in that epic because that's ultimately all I'm asking for here - update the detail page to match the new behavior that's now on the listing

@FranECross FranECross added the Blocked Issues that are blocked on factors other than blocking issues. label Aug 19, 2024
@jilladams jilladams added the accessibility Issues related to accessibility label Aug 23, 2024
@FranECross FranECross changed the title Update Download PDF link on Form detail pages to <button> element [BLOCKED] Update Download PDF link on Form detail pages to <button> element Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issues related to accessibility Blocked Issues that are blocked on factors other than blocking issues. Needs refining Issue status Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

3 participants