Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1 & 3 Components] Implement available components for Find a Form #17188

Closed
5 of 6 tasks
FranECross opened this issue Feb 9, 2024 · 3 comments
Closed
5 of 6 tasks

[V1 & 3 Components] Implement available components for Find a Form #17188

FranECross opened this issue Feb 9, 2024 · 3 comments
Assignees
Labels
Public Websites Scrum team in the Sitewide crew sitewide V3 Components Update to V3 VA.gov frontend CMS team practice area

Comments

@FranECross
Copy link

FranECross commented Feb 9, 2024

Description

The Design team is releasing a Typography update (sometime in March), which means that the PW team needs to upgrade any of our products where components aren't currently being using, but a V1 or V3 component is available.

If the updates aren't made prior to the Typography update, there's a chance that Veteran-facing issues may occur.

Pages:

Elements that are not using components that should be

  1. Link
    • We use this in one place but should be using the v1 component everywhere we can, including content inside inside accordions
    • We should also be using the appropriate variant (mainly download) for each instance
  2. Action Link
    • On the results list, there are a couple links that look like they should be using secondary action links but it's not. We are using an icon instead of the proper VADS class

User story

AS A PO/PM for Public Websites products
I WANT to implement available V1 or V3 components in features & products currently under Public Websites management where components aren't currently being used
SO THAT all PW products are in alignment with the current component version.
AND Veterans and other users have a consistent experience within VA.gov

Engineering notes / background

Analytics considerations

Quality / testing notes

Acceptance criteria

  • Links are using V1
  • Action Link the proper VADS class
  • other features display correctly
  • verify/review the E2E tests
  • check desktop and mobile
  • a11y review
@FranECross FranECross added Needs refining Issue status Public Websites Scrum team in the Sitewide crew V3 Components Update to V3 VA.gov frontend CMS team practice area labels Feb 9, 2024
@FranECross FranECross changed the title [V3 Components] Implement available V3 components for Find a Form [V3 Components] Implement available components for Find a Form Feb 15, 2024
@FranECross FranECross changed the title [V3 Components] Implement available components for Find a Form [V1 & 3 Components] Implement available components for Find a Form Feb 15, 2024
@FranECross FranECross removed the Needs refining Issue status label Feb 28, 2024
@FranECross
Copy link
Author

If breadcrumbs ISN'T content build, and is vets website, please add back to the ticket.

@randimays
Copy link
Contributor

Discovered more changes that need to be made in content-build. I'm working on these changes now, so this will carry over, but hopefully close tomorrow or Thursday.

@randimays
Copy link
Contributor

Successfully validated in production. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Public Websites Scrum team in the Sitewide crew sitewide V3 Components Update to V3 VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

3 participants