Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front end: Modify VAMC Medical record template to opt out of USWDS V3 automatic upgrade #17038

Closed
4 tasks done
xiongjaneg opened this issue Jan 25, 2024 · 5 comments
Closed
4 tasks done
Assignees
Labels
Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status sitewide VA.gov frontend CMS team practice area VAMC CMS managed product owned by Facilities team

Comments

@xiongjaneg
Copy link
Contributor

xiongjaneg commented Jan 25, 2024

User Story or Problem Statement

On 2/16, USWDS V1 components will default to V3. V1 components that have V3 versions will be automatically upgraded unless we opt out proactively. Opting out means: modifying those existing V1 components to pass in the uswds={false}.

VAMC Medical records template needs to be modified to opt out of V1 to V3 automatic upgrade.

List of applicable components

  • Alert
  • Accordion: Being used in Medical records section
  • Button
    • For reference, this was found inside the alert but we want to make sure all instance of button are opted out

Acceptance Criteria

  • Existing V1 components with a V3 equivalent are modified to pass in the uswds={false}
    • Alert: Currently using the v1 component
    • Accordion: Medical records accordion section is using v1 component
    • Button: It is inside the alert and is currently using the v1 component
@xiongjaneg xiongjaneg added Needs refining Issue status VAMC CMS managed product owned by Facilities team VA.gov frontend CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) labels Jan 25, 2024
@xiongjaneg
Copy link
Contributor Author

Hey team! Please add your planning poker estimate with Zenhub @eselkin @maxx1128

@eselkin
Copy link
Contributor

eselkin commented Jan 26, 2024

Only seems to have va-on-this-page, but may have more at vets-website.

@xiongjaneg
Copy link
Contributor Author

@eselkin @maxx1128 The description and ACs have been updated to identify the relevant components. Please repoint. Thank you!

@laflannery
Copy link
Contributor

I was updating this and noticed @eselkin comment so I want to make sure that the ask here is clear - we are only going to be modifying the components listed in each tickets because the other components (such as <va-on-this-page> as Eli mentioned do not have an v3 equivalent and potentially never will and we don't want to break those. CC: @xiongjaneg

@eselkin
Copy link
Contributor

eselkin commented Feb 13, 2024

If it's the button in the Sign in to manage your VA medical records, then it uses uswds="false", so it's good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status sitewide VA.gov frontend CMS team practice area VAMC CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

5 participants