Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitoring: We'd like to know when PPMS is not functioning #16927

Open
1 of 9 tasks
eselkin opened this issue Jan 19, 2024 · 1 comment
Open
1 of 9 tasks

Monitoring: We'd like to know when PPMS is not functioning #16927

eselkin opened this issue Jan 19, 2024 · 1 comment
Assignees
Labels
Facilities Facilities products (VAMC, Vet Center, etc) Facility Locator product owned by Facilities team Needs refining Issue status sitewide VA.gov frontend CMS team practice area

Comments

@eselkin
Copy link
Contributor

eselkin commented Jan 19, 2024

User Story or Problem Statement

Create datadog alert for error logs when PPMS is down

Description or Additional Context

Steps for Implementation

Acceptance Criteria

  • Testable_Outcome_X
  • Testable_Outcome_Y
  • Testable_Outcome_Z
  • Requires design review
  • Requires accessibility review

Team

Please check the team(s) that will do this work.

  • CMS Team
  • Public Websites
  • Facilities
  • Accelerated Publishing
@eselkin eselkin added Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status labels Jan 19, 2024
@eselkin eselkin self-assigned this Jan 19, 2024
@xiongjaneg xiongjaneg added VA.gov frontend CMS team practice area Facility Locator product owned by Facilities team labels Jan 22, 2024
@jilladams
Copy link
Contributor

jilladams commented Apr 10, 2024

We don't have access to know if PPMS is giving errors.
The request to vets-api will always return 200 even if PPMS signals an error. e.g. PPMS may send a 400 (warning) or 404 (also a warning) when the request has no data. But the request through vets-api returns 200 (success) and says empty data.

If we ever wanted to create this monitor, we would first need a vets-api ticket to better handle PPMS errors at that level to send back 400/404, rather than just 200s. (a la this work on Search to add 503/504 handling: https://github.com/department-of-veterans-affairs/vets-api/pull/15337/files) This is likely a product question: do we want to better process errors to show users, for example "no providers are available in this bounding box". That's the sort of thing that would return a 400.

If PPMS is down, though, we would be getting errors (500s). That never happens. PPMS is very slow, and will timeout or need 1min to get a response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc) Facility Locator product owned by Facilities team Needs refining Issue status sitewide VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

3 participants