Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VBA: Add local spotlights to query and template #16922

Closed
7 of 12 tasks
eselkin opened this issue Jan 19, 2024 · 4 comments
Closed
7 of 12 tasks

VBA: Add local spotlights to query and template #16922

eselkin opened this issue Jan 19, 2024 · 4 comments
Assignees
Labels
Facilities Facilities products (VAMC, Vet Center, etc) sitewide VA.gov frontend CMS team practice area

Comments

@eselkin
Copy link
Contributor

eselkin commented Jan 19, 2024

User Story or Problem Statement

As an editor or user I want to see the local spotlight fields in the VBA page

Description or Additional Context

Get featured content from local spotlights and merge them into list with single centralized content

Steps for Implementation

  • Add fieldLocalSpotlight to VBA GQL query
  • Check if fieldLocalSpotlight has length (has items)
  • If fieldLocalSpotlight has items add featured content to array of items being processed for spotlights

Acceptance Criteria

  • fieldLocalSpotlight is downloaded from drupal
  • local spotlights are visible on page
  • If no fieldLocalSpotlight items, no spotlight sections are added
  • Requires design review
  • Requires accessibility review

Team

Please check the team(s) that will do this work.

  • CMS Team
  • Public Websites
  • Facilities
  • Accelerated Publishing
@eselkin eselkin added Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status labels Jan 19, 2024
@eselkin
Copy link
Contributor Author

eselkin commented Jan 19, 2024

fieldLocalSpotlight is a ParagraphFeaturedContent and is accessed via its entity:

fieldLocalSpotlight {
      entity {
        entityRevisions { 
            entities {
          	... on ParagraphFeaturedContent {
            	id
                 fieldDescription {
                      value
                      format
                      processed
               }
              fieldCta{
                entity {
                  ... on ParagraphButton {
                    fieldButtonLink {
                      uri
                      title
                      options
                    }
                    fieldButtonLabel
                  }
                }
              }
            }
          }
        }
      }
    }

Data is not retrieved in a fetched field and therefore requires building a liquid filter to pre-process the data

@eselkin eselkin added VA.gov frontend CMS team practice area and removed Needs refining Issue status labels Jan 19, 2024
@eselkin eselkin self-assigned this Jan 23, 2024
@jilladams
Copy link
Contributor

@eselkin can you confirm that @thejordanwood and @laflannery were able to do the design / a11y review here? Those are the last ACs in order to close. If not, may need to re-standup a tugboat with content populated, so they can see it.

@eselkin
Copy link
Contributor Author

eselkin commented Jan 28, 2024

I sort of accidentally added those. But since they had viewed the original 3 spotlight elements with the non-local spotlights and they were using the same components just different data, I didn't think they needed to do a second check.

@jilladams
Copy link
Contributor

Fair - if design / markup are the same, just content differences, makes sense to me. (FYI @laflannery / @thejordanwood in case you have any questions.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc) sitewide VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

2 participants