Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discharge Upgrade Wizard] (#2) FE: Add Branch and Year/Month Questions #16910

Closed
4 tasks done
chriskim2311 opened this issue Jan 18, 2024 · 6 comments
Closed
4 tasks done
Assignees
Labels
Discharge upgrade wizard Product owned by Public Websites team Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area

Comments

@chriskim2311
Copy link
Contributor

chriskim2311 commented Jan 18, 2024

Description

Ticket 2

User story

AS A Veteran
I WANT to be see the Branch and Year and Month questions of the DUW in a subtask pattern
SO THAT I get continue the wizard experience.

Engineering notes:

  • Add Branch question
  • Add Year of Discharge question
  • Add Month of Discharge question
  • Create routes for those
  • Display conditions ("decision tree") for these 3 questions
  • Redux store for answer storage
  • review the existing content for typos
  • Form error handling
  • Testing: Cypress tests
  • Testing: Unit tests (for display conditions logic)

Acceptance criteria

  • Question is on a single screen (sub-task pattern)
  • Content changes per below
  • A11y review
  • Design review

Content Changes

Existing Text:

Q1: In which branch of service did you serve?

  1. Army
  2. Navy
  3. Air Force
  4. Coast Guard
  5. Marine Corps

Q2: What year were you discharged from the military?
[ year selector ]

Q2a: What month were you discharged?
[ month selector ]

Updated Text (not all text is updated; but I included all text to reduce confusion):

Q1: What was your branch of service?

  1. Army
  2. Navy
  3. Air Force
  4. Coast Guard
  5. Marine Corps

Q2: What year were you discharged from the military?
[ year selector ]
If Q2 == CURRENTYEAR - 15, show:
Q2a: What month were you discharged?
[ month selector ]

Questions:

  • What should the form error message say (if an answer is not selected when clicking Continue)?
    • Answer: These are the error messages that should appear on each field:
      • For Year of Discharge: Select a year
      • For Month of Discharge: Select a month
@chriskim2311 chriskim2311 added Discharge upgrade wizard Product owned by Public Websites team Public Websites Scrum team in the Sitewide crew labels Jan 18, 2024
@chriskim2311 chriskim2311 changed the title Copy of [Discharge Upgrade Wizard]: Initial App Setup [Discharge Upgrade Wizard] FE: Add Branch and Year/Month Questions Jan 18, 2024
@FranECross FranECross changed the title [Discharge Upgrade Wizard] FE: Add Branch and Year/Month Questions [Discharge Upgrade Wizard] (#2) FE: Add Branch and Year/Month Questions Jan 19, 2024
@FranECross FranECross added the VA.gov frontend CMS team practice area label Jan 19, 2024
@chriskim2311 chriskim2311 self-assigned this Mar 19, 2024
@FranECross
Copy link

@thejordanwood Will you please take a look at the question Chris has in the Description? I'm happy to create a ticket for you to track your time and pull into a sprint when you're able to do the work. Thanks! cc @chriskim2311

@thejordanwood
Copy link

If an answer is not selected, these are the error messages that should appear on each field:

  • For Year of Discharge: Select a year
  • For Month of Discharge: Select a month

cc: @FranECross @chriskim2311

@chriskim2311
Copy link
Contributor Author

This will carry over to next sprint

@FranECross
Copy link

@chriskim2311 For when you're back, I added the content changes we chatted about (existing text/updated text), and will include in the other stories as well. Thanks!

@chriskim2311
Copy link
Contributor Author

This is ready for review but will carry over, pending some unit tests fixes

@chriskim2311
Copy link
Contributor Author

Verified changes are not live on prod but in staging. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discharge upgrade wizard Product owned by Public Websites team Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

4 participants