Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R&S Editor: Remove Tag/Topic selection restrictions #16574

Closed
2 tasks
Tracked by #16828
FranECross opened this issue Dec 27, 2023 · 3 comments · Fixed by #16854
Closed
2 tasks
Tracked by #16828

R&S Editor: Remove Tag/Topic selection restrictions #16574

FranECross opened this issue Dec 27, 2023 · 3 comments · Fixed by #16854
Assignees
Labels
backend Drupal engineering CMS team practice area Public Websites Scrum team in the Sitewide crew Resources and support CMS managed product owned by Public Websites team sitewide

Comments

@FranECross
Copy link

FranECross commented Dec 27, 2023

Description

There is a mechanism controlling the total amount of "Tags" (the sum of all topics and beneficiaries/non-beneficiaries), which limits the total amount to 4. The current behavior works by counting the total number of Tags, including Topics and Beneficiaries, with the intent to cap the total to 4. Once the editor makes a total of 4 selections, the Tags field is locked for further editing.

We have approval from Mikki/Danielle to remove the restrictions completely.

User story

AS A editor of Resources & Support node
I WANT to be able to add multiple Beneficiary types as well as multiple topics, without restriction
SO THAT the R&S page more accurately represents reality.

Engineering notes / background

  • this is a fast-follow ticket in conjunction with #13188

Analytics considerations

Quality / testing notes

Acceptance criteria

  • Change the help text, removing the maximum of 4 statement.
  • Update the code to not restrict/lock out the Topics field at all (IOW an editor may add as many topics / beneficiaries to an article as they like)

GIVEN: A resources and support node editor is creating an article
WHEN: the editor adds 4 or more beneficiaries
THEN: the editor may add 1 to all the remaining topics
AND the editor encounters no errors and is able to publish / save the article (e.g. editor may add all beneficiaries and all topics successfully; no restrictions)

@FranECross FranECross added Needs refining Issue status Public Websites Scrum team in the Sitewide crew Drupal engineering CMS team practice area backend labels Dec 27, 2023
@FranECross FranECross removed the Needs refining Issue status label Jan 9, 2024
@jilladams jilladams added the Resources and support CMS managed product owned by Public Websites team label Jan 16, 2024
@jilladams
Copy link
Contributor

Pulling into Sprint 101, likely to roll into 102, in order to fix #16850, correlated new bug.

@jilladams
Copy link
Contributor

REopening to verify in prod

@jilladams
Copy link
Contributor

Verified in Staging (which is prod mirrored) as Megan Zehnder (CAIA). All 6 R&S content types allow >4 tags to be applied, across Tags / Beneficiaries field.

  • checklist
  • media_list_images
  • media_list_videos
  • step_by_step
  • faq_multiple_q_a
  • q_a
  • support_resources_detail_page

I hadn't previously noticed, but Non-beneificiaries is still a radio button. Not an issue, not in scope for any changes here or in 13188, but just noting since I noticed it.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Drupal engineering CMS team practice area Public Websites Scrum team in the Sitewide crew Resources and support CMS managed product owned by Public Websites team sitewide
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants