Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor banners in next-build #16432

Closed
4 of 5 tasks
Tracked by #16510 ...
tjheffner opened this issue Dec 14, 2023 · 0 comments
Closed
4 of 5 tasks
Tracked by #16510 ...

Refactor banners in next-build #16432

tjheffner opened this issue Dec 14, 2023 · 0 comments

Comments

@tjheffner
Copy link
Contributor

tjheffner commented Dec 14, 2023

Requirements

There are multiple banners being fetched from our endpoint, and the query format is not the same as the rest of our queries. Clean this up.

Github also reports a number of alerts for unused variables related to the FacilityBanner

Acceptance criteria

Preview Give feedback

Background & implementation details

The set of banners that should be tested to work:

  • Full Width Banner Alerts | banner
  • Facilities Banners | full_width_banner_alert
  • Promo banners | promo_banner

Implementation tasks

Preview Give feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants