-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PW intake: <Add Spanish toggle and set up left nav> from <Sitewide CAIA> #16393
Comments
@randimays @chriskim2311 @dsasser Does this request need a Drupal as well as an FE ticket? Thanks in advance! |
@FranECross I don't think we need FE changes, but I can't say that with 100% certainty. At minimum, I think we need to make the Drupal changes and see how things render on the FE first.
|
@randimays for the Supplemental Claims page, this is the static page and not the "File a Supplemental Claim" page. The left nav for this would be; Reclamaciones complementarias And you're right about the harassment page not needing the left nav. We would want the Spanish page to match the behavior of the English version. Thank you! |
@randimays Will you please take a look at Randi Hecht's comment above and let me know if her info/response unblocks this ticket? Thanks! |
@FranECross I believe this is the ticket we discussed in planning last week. We decided that #15759 may pave the way to fixing this issue, so we were going to wait until that ticket was resolved to try to tackle this one. |
The ticket formerly blocking this one has been completed, paving the way for this to be worked on |
@FranECross would your team be able to prioritize the more recent toggle ticket I opened yesterday over this one? #16392 We'd love to get this one live before the end of the year if at all possible. Thank you! |
For end of sprint, noting: pulled in as stretch, a couple tests failing in the PR. I've updated branch to see if that/new run shake it loose. Moved to Review/QA pre-merge. Added Chris as PR reviewer. |
Update: PR for the English/Spanish toggles has been merged and will deploy to prod today. The missing left nav items are in progress on a Tugboat. Hoping those will finish today as well. |
@FranECross @jilladams The menu data has been added into a Tugboat. Could you please sanity check these for me, then I can add the menu data into production?
|
@randimays I'll be happy to! I'll take a look at it after sprint planning. Thanks! |
Thanks @jilladams, I'll get the menu data added to prod! |
Looks great, @randimays !! 🎉 |
Indicate if you need front-end engineering support for
Describe your request
We've published 2 pages in Spanish that we need to set up the left nav for and add the Spanish toggle at the top of the page.
These pages are:
Time constraints / launch deadlines
Your product/team Slack channel
Your OCTODE product owner
Notify Sitewide Public Websites of this issue, and tag @fran Cross & @jilladams.
#sitewide-public-websites
in Slack after submitting this issue.Acceptance Criteria
@FranECross turn this into an FE ticket
The text was updated successfully, but these errors were encountered: