Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PW intake: <Add Spanish toggle and set up left nav> from <Sitewide CAIA> #16393

Closed
2 of 11 tasks
Tracked by #16428
RLHecht opened this issue Nov 20, 2023 · 16 comments
Closed
2 of 11 tasks
Tracked by #16428

PW intake: <Add Spanish toggle and set up left nav> from <Sitewide CAIA> #16393

RLHecht opened this issue Nov 20, 2023 · 16 comments
Assignees
Labels
FE Translation Translation toggles and menus using FE React component Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area

Comments

@RLHecht
Copy link
Collaborator

RLHecht commented Nov 20, 2023

Indicate if you need front-end engineering support for

  • Content audit
  • Implementation of REACT sign-in widgets
  • Support for UAT testing or phased roll out of app/tool landing page
  • Implementation of Translation widgets
  • Something else

Describe your request

We've published 2 pages in Spanish that we need to set up the left nav for and add the Spanish toggle at the top of the page.

These pages are:

Time constraints / launch deadlines

  • no hard timing

Your product/team Slack channel

  • Sitewide CAIA

Your OCTODE product owner

  • Randi Hecht

Notify Sitewide Public Websites of this issue, and tag @fran Cross & @jilladams.

  • I acknowledge that I must notify #sitewide-public-websites in Slack after submitting this issue.

Acceptance Criteria

  • Add menu links to drupal (doesn't need engineer to do this; @FranECross check with Jill)
    @FranECross turn this into an FE ticket
  • Left nav displays in Spanish for the -esp pages noted above
  • Front end ticket is created for:
    • Breadcrumb for the particular pages displays in Spanish
    • Toggles for English | Español display toward the top of the pages
@RLHecht RLHecht added Public Websites Scrum team in the Sitewide crew Needs refining Issue status labels Nov 20, 2023
@FranECross
Copy link

@randimays @chriskim2311 @dsasser Does this request need a Drupal as well as an FE ticket? Thanks in advance!

@randimays
Copy link
Contributor

@FranECross I don't think we need FE changes, but I can't say that with 100% certainty. At minimum, I think we need to make the Drupal changes and see how things render on the FE first.

  • /decision-reviews/supplemental-claim-esp: we need to add the Spanish link/translation to File a Supplemental Claim in the Decision reviews menu in Drupal. This page is using the same template as another set with language toggles (/health-care-how-to-apply)
  • /report-harassment-esp: this one's English page doesn't have a sidebar at all. I assume we need to add a menu in Drupal and assign it to this page. It's also using the same template as the working set with language toggles.

@RLHecht
Copy link
Collaborator Author

RLHecht commented Nov 27, 2023

@randimays for the Supplemental Claims page, this is the static page and not the "File a Supplemental Claim" page. The left nav for this would be; Reclamaciones complementarias

And you're right about the harassment page not needing the left nav. We would want the Spanish page to match the behavior of the English version. Thank you!

@jilladams jilladams added VA.gov frontend CMS team practice area Drupal engineering CMS team practice area labels Nov 27, 2023
@FranECross FranECross added the Blocked Issues that are blocked on factors other than blocking issues. label Nov 29, 2023
@FranECross
Copy link

@randimays Will you please take a look at Randi Hecht's comment above and let me know if her info/response unblocks this ticket? Thanks!

@randimays
Copy link
Contributor

@FranECross I believe this is the ticket we discussed in planning last week. We decided that #15759 may pave the way to fixing this issue, so we were going to wait until that ticket was resolved to try to tackle this one.

@FranECross FranECross removed the Blocked Issues that are blocked on factors other than blocking issues. label Dec 12, 2023
@FranECross
Copy link

The ticket formerly blocking this one has been completed, paving the way for this to be worked on

@RLHecht
Copy link
Collaborator Author

RLHecht commented Dec 12, 2023

@FranECross would your team be able to prioritize the more recent toggle ticket I opened yesterday over this one? #16392 We'd love to get this one live before the end of the year if at all possible. Thank you!

@jilladams
Copy link
Contributor

jilladams commented Dec 12, 2023

I went ahead and updated #16392 with that in mind. Thanks for flagging, @RLHecht

@jilladams jilladams transferred this issue from department-of-veterans-affairs/va.gov-team Dec 12, 2023
@FranECross FranECross added VA.gov frontend CMS team practice area and removed Drupal engineering CMS team practice area VA.gov frontend CMS team practice area labels Dec 12, 2023
@FranECross FranECross removed the Needs refining Issue status label Dec 14, 2023
@jilladams jilladams added the FE Translation Translation toggles and menus using FE React component label Dec 19, 2023
@randimays randimays assigned randimays and unassigned jilladams and FranECross Dec 22, 2023
@jilladams
Copy link
Contributor

jilladams commented Dec 29, 2023

For end of sprint, noting: pulled in as stretch, a couple tests failing in the PR. I've updated branch to see if that/new run shake it loose. Moved to Review/QA pre-merge. Added Chris as PR reviewer.

@randimays
Copy link
Contributor

Update: PR for the English/Spanish toggles has been merged and will deploy to prod today. The missing left nav items are in progress on a Tugboat. Hoping those will finish today as well.

@randimays
Copy link
Contributor

@FranECross @jilladams The menu data has been added into a Tugboat. Could you please sanity check these for me, then I can add the menu data into production?

/decision-reviews/supplemental-claim/
/decision-reviews/supplemental-claim-esp/

@FranECross
Copy link

@randimays I'll be happy to! I'll take a look at it after sprint planning. Thanks!

@jilladams
Copy link
Contributor

(took a quick look while working on sprint report, ✅ , and new toggles / no sidebar page looks good too)
Screenshot 2024-01-03 at 12 57 57 PM
Screenshot 2024-01-03 at 12 57 48 PM

@randimays
Copy link
Contributor

Thanks @jilladams, I'll get the menu data added to prod!

@FranECross
Copy link

Looks great, @randimays !! 🎉

@randimays
Copy link
Contributor

Everything is confirmed in production. Closing!

/report-harassment (toggles only)

Screenshot 2024-01-03 at 5 07 12 PM Screenshot 2024-01-03 at 5 07 01 PM



/decision-reviews/supplemental-claim (toggles & sidebar)

Screenshot 2024-01-03 at 5 06 50 PM Screenshot 2024-01-03 at 5 06 40 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FE Translation Translation toggles and menus using FE React component Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

4 participants