Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public websites to vets-api codeowners file for our apps #15868

Closed
1 task done
Tracked by #15992
jilladams opened this issue Oct 26, 2023 · 5 comments
Closed
1 task done
Tracked by #15992

Add public websites to vets-api codeowners file for our apps #15868

jilladams opened this issue Oct 26, 2023 · 5 comments
Assignees
Labels
Find a form CMS managed product, owned by Public Websites team Income limits app Income limits web app re: benefits eligibility; owned by Public Websites team Public Websites Scrum team in the Sitewide crew Ruby sitewide VA.gov frontend CMS team practice area

Comments

@jilladams
Copy link
Contributor

jilladams commented Oct 26, 2023

Description or Additional Context

@vfs-public-websites-frontend is not available in vets-api as a codeowner, apparently.
Slack thread: https://dsva.slack.com/archives/C52CL1PKQ/p1698278079886099

At minimum, we should be listed as codeowners for apps we build and maintain, including:

  • Find a form (forms api)
  • Income limits

Acceptance Criteria

  • Public Websites is listed as codeowner of our team's vets-api related applications
@jilladams jilladams added the Needs refining Issue status label Oct 26, 2023
@jilladams
Copy link
Contributor Author

This is Ruby, Ruby is weird, it's backend of the frontend, so we call it front end so it'll show up in sprint board labels.

@jilladams jilladams added VA.gov frontend CMS team practice area Find a form CMS managed product, owned by Public Websites team Public Websites Scrum team in the Sitewide crew Income limits app Income limits web app re: benefits eligibility; owned by Public Websites team Ruby labels Oct 26, 2023
@jilladams
Copy link
Contributor Author

Note: I'm requesting we get our FE Github team renamed to vfs (instead of vsa).

Platform support request Slack: https://dsva.slack.com/archives/CBU0KDSB1/p1698336681097449

We'll need to make codeowners changes at the same time, if they do change it:

@jilladams
Copy link
Contributor Author

May require opening a Platform Support ticket to get @vfs-public-websites-frontend added to vets-api repo with write permissions.

@randimays
Copy link
Contributor

I created a PR here for review. I also requested Platform add our team to the vets-api repo as owners. They added us, and it's working!

@dsasser @jilladams @jtmst could you please review the above PR when you have a chance, and let me know if there's anything I'm missing?

@randimays
Copy link
Contributor

Josh reviewed the PR. Since he's the most familiar with vets-api, I think we're good to merge. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Find a form CMS managed product, owned by Public Websites team Income limits app Income limits web app re: benefits eligibility; owned by Public Websites team Public Websites Scrum team in the Sitewide crew Ruby sitewide VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

3 participants