Resolve content model tentacles on 10089 Events checkbox #15641

jilladams · 2023-10-11T01:12:17Z

Description

#10089 added an Events checkbox to the Events form.
This change shipped and broke the content model in the front end in 2 known places:

Outreach Materials -- not displaying Publications in VA.gov frontend
VAMC Stories (example) -- "See all stories" link is missing at the foot of the page.
We also need to re-verify Lovell, per Tim, though still no smoking gun for what that might mean

Slack threads

Topline for DaveC

Engineering notes

Feature Toggle may still be "ON" in prod, despite the revert of our code which created it.

We need to be careful about the FEATURE_EVENT_OUTREACH_CHECKBOX feature toggle being deployed as "enabled". The latest CMS mirror is showing it as enabled, but unsure if this was because the snapshot was taken before the revert was deployed.

Everywhere field_listing is used in templates/queries

10 results - 6 files

src/site/layouts/news_story.drupal.liquid:
  45                      </div>
  46:                     {% if fieldListing.entity.entityUrl.path %}
  47:                         <a onClick="recordEvent({ event: 'nav-secondary-button-click' });" class="vads-u-display--block vads-u-margin-bottom--7" href="{{ fieldListing.entity.entityUrl.path }}" id="news-stories-listing-link">See all stories</a>
  48                      {% endif %}

src/site/layouts/publication_listing.drupal.liquid:
  87                {% for entity in outreachAssetsDataArray.entities %}
  88                {% for entity in outreachAssetsDataArray.entities %}
  89:               {% if entity.fieldListing.targetId == entityId %}
  89                {% assign topicsString = entity.fieldLcCategories | buildTopicsString %}
  90                {% assign topicsString = entity.fieldLcCategories | buildTopicsString %}

src/site/stages/build/drupal/process-lovell-pages.js:
  69  
  70  
  71:   if (page?.fieldListing?.entity?.entityUrl) {
  72:     page.fieldListing.entity.entityUrl.path = getLovellVariantOfUrl(
  73:       page.fieldListing.entity.entityUrl.path,
  73        variant,
  74        variant,

src/site/stages/build/drupal/graphql/newStoryPage.graphql.js:
  33      }
  34:     fieldListing {
  35        entity {

src/site/stages/build/drupal/graphql/nodeEvent.graphql.js:
  114      }
  115      }
  116:     fieldListing {

  116        entity {
  117        entity {

  284      }
  285      }
  286:     fieldListing {
  286        entity {
  287        entity {

src/site/stages/build/drupal/graphql/file-fragments/outreachAssets.graphql.js:
  13          fieldDescription
  14:         fieldListing {
  15            targetId

ACs.

BE: Events: Add "national outreach calendar" checkbox to Event UI #10089 changes are present and
- Outreach materials present Publications correctly at /outreach-and-events/outreach-materials/
- Stories display a link at page footer to "See all stories"
- Lovell is verified. Talk to Tim and maybe Ryan to clarify what needs verified.
Ensure the feature toggle FEATURE_EVENT_OUTREACH_CHECKBOX does not deploy as 'enabled'.
AP are added as code reviewers on any related PRs (CMS, or FE)
Deployment plan is in place, as FE changes will be required this time.
A11y review completed

Deployment Plan

Test changes in both this PR, and the related content-build together in a tugboat environment. Completed by Jill October 20, 2023 on this tugboat.
A11y confirmation/testing by @laflannery in tugboat
PRs (BE 15761, FE c-b 1752) approved by PW and AP teams
Merge the BE PR.
Wait for deployment of the BE PR and test success.
Merge the FE PR.

The text was updated successfully, but these errors were encountered:

jilladams · 2023-10-11T17:35:47Z

Estimate doesn't factor Lovell complexity. Daniel to talk to AP folks and update as needed with Lovell in mind.

dsasser · 2023-10-19T16:29:25Z

Mid-sprint Update 10/19/23

When taking on this ticket, we were planning no architectural changes on the backend, and instead making the frontend (content-build) robust enough to handle both a single value and an array of values. However, this approach had a lot of technical debt built in, and little risk mitigation was possible.

Because of this, we are pivoting to a different architecture:

Backend Changes

We will create a new field on the Event content type on the BE.
This field will hold 'additional listings' (it is an entity reference field, just like field_listing)
It will be hidden from view, and only populated with the correct Outreach calendar Event Listing reference if the checkbox is set.

Frontend (content-build) Changes

An additional Graphql reverse entity query will be added to the existing nodeEventListing query, in the same way that the field_listing data is done.
We will combine the event data from the two queries prior to piping into the event listing template. This will allow us to inject the data in a single location, without affecting vets-website's related React widget (we won't need to worry about combining, sorting, or other tasks beyond what we are doing in content-build).

Overall this approach is much safer, since we aren't touching the structure of an existing field, but adding another field which is brand new to the ecosystem.

jilladams · 2023-10-19T17:23:15Z

@dsasser I like this and also: it smells like we may get questions at code review time. Would it be worth bouncing this off any other Drupal folks for smell testing before we fully commit? Or feels very safe / uncontroversial as a fix?

dsasser · 2023-10-19T18:13:02Z

@dsasser I like this and also: it smells like we may get questions at code review time. Would it be worth bouncing this off any other Drupal folks for smell testing before we fully commit? Or feels very safe / uncontroversial as a fix?

Getting feedback during review time is adequate in this case.

jilladams · 2023-10-20T21:31:12Z

Testing notes:
Thread related to testing: https://dsva.slack.com/archives/C52CL1PKQ/p1697837268281799?thread_ts=1697835404.910689&cid=C52CL1PKQ

Tugboat with feature toggle enabled: https://cms-ytipldihujdcko41uemzx3w18e31hyof.ci.cms.va.gov/admin/config/system/feature_toggle
FE: https://web-ytipldihujdcko41uemzx3w18e31hyof.ci.cms.va.gov/

Editor login, roles, section	Event type	Expected behavior	Pass/fail in CMS	Pass/fail in FE
[email protected], Content creator - VAMC / Content publisher	event VAMC event AK, not Natl, recurring	Shoudn't see national checkbox	🟢 checkbox does not appear	🟢 Event published normally; AK Events listing fine
[email protected]; Content creator - outreach hub, Content publisher	event Outreach event, recurring	Shouldn't see the checkbox	🟢 checkbox does not appear	🟢 Event publishes correctly, appears on pg 7 of Outreach events, in correct sequence
[email protected] - shortlisted beta editor, Content creator - VAMC Bedford & Boston / Content publisher	event VAMC event, Boston, not recurring. National.	Should see / select National checkbox. Event should publish to Natl calendar	🟢 checkbox appears, is selected /s aved.	🟢 Event single page; Boston listing; Outreach calendar page 5 of results
[email protected] - shortlisted beta editor, Content creator - VAMC Bedford & Boston / Content publisher	event VAMC event, Bedford, not recurring. National.	Should see / select National checkbox. Event should publish to Natl calendar	🟢 checkbox appears, is selected /s aved.	- 🟢 single page - 🟢 Bedford listing - first occurrence appears. - 🟢 Outreach events listing first occurrence appears pg 7, 11/6; no further occurrences appear (11/13, pg 11).

Other FE tests:

Listings:

🟢 Stories - see all link is present / works (e.g. https://www.va.gov/minneapolis-health-care/stories/leading-the-way-in-stroke-care-for-veterans-at-the-minneapolis-va-health-care-system/)
🟢 Outreach materials - lists publications ,
🟢 Outreach events cal - displays events correctly in order, when national checkbox ones interleaved
🟢 Outreach events cal - Filters work for
- Date range
- Specific date
- past

Recurring events: expected behavior

In production today, for a recurring event, only the next upcoming instance will appear in the Upcoming filter.
https://www.va.gov/minneapolis-health-care/events/48206/
https://www.va.gov/minneapolis-health-care/events/?selectedOption=upcoming

10/23 recurrence appears
10/30 recurrence does not

https://www.va.gov/outreach-and-events/events/61561/
https://www.va.gov/outreach-and-events/events/

10/31 recurrence appears
11/7 recurrence does not

dsasser · 2023-10-23T15:52:00Z

Deployment Plan

Test changes in both this PR, and the related content-build together in a tugboat environment. Completed by Jill October 20, 2023 on this tugboat.
A11y confirmation/testing by @laflannery in tugboat
PRs (BE, FE) approved by PW and AP teams
Merge the BE PR.
Wait for deployment of the BE PR and test success.
Merge the FE PR.

Jill meddled here

I moved this list as checkboxes into the body of the ticket, so it's easy to see next to ACs for modern state of truth.

dsasser · 2023-10-23T16:16:12Z

@laflannery when you get a chance, could you review this PR for a11y + breadcrumb signoff? Tugboat is hit or miss today, but you should be able to get in eventually if you keep trying. There is a list of existing FE pages that Jill created while testing that might be of interest to you.

laflannery · 2023-10-23T16:56:20Z

@dsasser I got in for a bit but wasn't able to test everything yet. However I do have one general QA item I wanted to mention - I saw this issue that I had flagged as a D10 issue and thought had been resolved in a previous ticket. Is it a problem that it's here in this tugboat?

jilladams · 2023-10-23T17:24:44Z

@dsasser @laflanner I see what Laura is seeing here: https://cms-ytipldihujdcko41uemzx3w18e31hyof.ci.cms.va.gov/node/62493/edit

I tried to repro that, using this new event: https://cms-ytipldihujdcko41uemzx3w18e31hyof.ci.cms.va.gov/node/62522/edit

Created a new recurring event - don't see the 2nd set of date fields, in the Add form
Saved as draft - don't see 2nd set of fields when editing after draft save
Published - still don't see 2nd set of fields
Modified recurrence from days to weeks = this change weirdly allowed me to save, but when I review, it removed my date data from the original event date settings (GAH, new bug, need to file it). https://cms-ytipldihujdcko41uemzx3w18e31hyof.ci.cms.va.gov/node/62522/revisions/view/817739/817740/visual_inline

Then got a 502. 😂 but will check when it's back up, re: whether the 2nd date fields appear.

dsasser · 2023-10-23T17:30:55Z

@dsasser @laflanner I see what Laura is seeing here: https://cms-ytipldihujdcko41uemzx3w18e31hyof.ci.cms.va.gov/node/62493/edit

I tried to repro that, using this new event: https://cms-ytipldihujdcko41uemzx3w18e31hyof.ci.cms.va.gov/node/62522/edit

Created a new recurring event - don't see the 2nd set of date fields, in the Add form

Saved as draft - don't see 2nd set of fields when editing after draft save

Published - still don't see 2nd set of fields

Modified recurrence from days to weeks = this change weirdly allowed me to save, but when I review, it removed my date data from the original event date settings (GAH, new bug, need to file it). https://cms-ytipldihujdcko41uemzx3w18e31hyof.ci.cms.va.gov/node/62522/revisions/view/817739/817740/visual_inline

Then got a 502. 😂 but will check when it's back up, re: whether the 2nd date fields appear.

I'm still not clear how to reproduce what you and @laflannery are seeing w/ the 2nd set of date fields. Noting that this would be an unexpected change, since we didn't change those fields in any way intentionally.

laflannery · 2023-10-23T17:46:36Z

@dsasser and @jilladams some notes:

I think that extra fieldset is only showing on recurring events
- I can see it on the 3 recurring events you have in the table above but NOT in the one non-recurring event and not in the new non-recurring event you made
In the previous ticket, the D10 one, the issue was the combination of the version of the events module and D10 that caused that extra fieldset to show. Daniel and Edmund worked on it together to resolved that.
- This Tugboat is not on D10 but I'm wondering if this is a new version of the module that is not working with our current version of Drupal?

jilladams · 2023-10-23T17:46:45Z

The D10 note is interesting - I know the CMS team was most recently planning to ship that 1st week of November. So I just realized: wow, we need to take that into account with this launch. I'll ping CMS channelt o confirm timing.

dsasser · 2023-10-23T17:47:52Z

@laflannery what is the behavior on staging/prod?

laflannery · 2023-10-23T17:55:47Z

Staging has this same behavior and shows me the extra fieldset:

So that being said I feel like I (or someone?) should just ignore this entirely here and ticket this separately right?

jilladams · 2023-10-23T18:04:00Z

Yes, good call. If in Staging, officially not tied to this feature and we can/should handle separately.

laflannery · 2023-10-23T18:47:04Z

So back to what I was actually supposed to be reviewing, using the table from Jill above:

Scenario 1

FE breadcrumbs look good (it has the VAMC breadcrumbs as expected)
FE accessibility approved

Scenario 2

FE breadcrumbs look good (it has the Outreach breadcrumbs as expected)
FE accessibility approved

Scenario 3

FE breadcrumbs look good (it has the VAMC breadcrumbs coming from both listings as expected)
FE accessibility approved

Scenario 4

FE breadcrumbs look good (it has the VAMC breadcrumbs coming from both listings as expected)
FE accessibility approved

CMS

Tested logged in as me, Winfield and Timothy, no issues in any of those experiences. Approved

jilladams · 2023-10-23T22:17:36Z

( Noting: all test data at tugboat links i comments above got blown away by Tugboat refresh. )

laflannery · 2023-10-24T00:29:33Z

Everything is approved by me, breadcrumbs look good and not a11y issues!

jilladams added Defect Something isn't working (issue type) Public Websites Scrum team in the Sitewide crew Events product maintained by Public Websites team labels Oct 11, 2023

jilladams mentioned this issue Oct 11, 2023

BE: Events: Add "national outreach calendar" checkbox to Event UI #10089

Closed

12 tasks

jilladams added Needs refining Issue status VA.gov frontend CMS team practice area labels Oct 11, 2023

jilladams mentioned this issue Oct 11, 2023

PW Sprint 95 #15586

Closed

28 tasks

jilladams added Drupal engineering CMS team practice area and removed Needs refining Issue status labels Oct 11, 2023

jilladams assigned dsasser Oct 11, 2023

This was referenced Oct 11, 2023

Discovery: Learn how the notifications framework works & map plan for Q4 notifications work #15533

Closed

Update Events CMS feature toggle to expose Events checkbox to a specific set of usernames #13529

Closed

jilladams mentioned this issue Oct 19, 2023

Enable Event editors to feature an event on the Outreach & Events list (AKA Events Calendar Single Source of Truth) #13527

Closed

11 tasks

dsasser mentioned this issue Oct 20, 2023

VACMS-15641 national outreach checkbox #15761

Merged

9 tasks

jilladams mentioned this issue Oct 20, 2023

Determine Permissions and/or Sections #13530

Closed

dsasser mentioned this issue Oct 23, 2023

VACMS-15641: Adds 'add to National Outreach Calendar' checkbox department-of-veterans-affairs/content-build#1752

Merged

7 tasks

jilladams mentioned this issue Oct 25, 2023

FE: Update FE to handle new Events checkbox backend #15856

Closed

7 tasks

jilladams closed this as completed Oct 25, 2023

jilladams removed the VA.gov frontend CMS team practice area label Oct 25, 2023

jilladams added the sitewide label Jun 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Resolve content model tentacles on 10089 Events checkbox #15641

Resolve content model tentacles on 10089 Events checkbox #15641

jilladams commented Oct 11, 2023 •

edited by dsasser

Loading

jilladams commented Oct 11, 2023

dsasser commented Oct 19, 2023

jilladams commented Oct 19, 2023

dsasser commented Oct 19, 2023

jilladams commented Oct 20, 2023 •

edited

Loading

dsasser commented Oct 23, 2023 •

edited by jilladams

Loading

dsasser commented Oct 23, 2023 •

edited

Loading

laflannery commented Oct 23, 2023 •

edited

Loading

jilladams commented Oct 23, 2023

dsasser commented Oct 23, 2023

laflannery commented Oct 23, 2023 •

edited

Loading

jilladams commented Oct 23, 2023

dsasser commented Oct 23, 2023

laflannery commented Oct 23, 2023

jilladams commented Oct 23, 2023

laflannery commented Oct 23, 2023 •

edited

Loading

jilladams commented Oct 23, 2023

laflannery commented Oct 24, 2023

Resolve content model tentacles on 10089 Events checkbox #15641

Resolve content model tentacles on 10089 Events checkbox #15641

Comments

jilladams commented Oct 11, 2023 • edited by dsasser Loading

Description

Slack threads

Engineering notes

ACs.

Deployment Plan

jilladams commented Oct 11, 2023

dsasser commented Oct 19, 2023

Mid-sprint Update 10/19/23

jilladams commented Oct 19, 2023

dsasser commented Oct 19, 2023

jilladams commented Oct 20, 2023 • edited Loading

Other FE tests:

Recurring events: expected behavior

dsasser commented Oct 23, 2023 • edited by jilladams Loading

Deployment Plan

Jill meddled here

dsasser commented Oct 23, 2023 • edited Loading

laflannery commented Oct 23, 2023 • edited Loading

jilladams commented Oct 23, 2023

dsasser commented Oct 23, 2023

laflannery commented Oct 23, 2023 • edited Loading

jilladams commented Oct 23, 2023

dsasser commented Oct 23, 2023

laflannery commented Oct 23, 2023

jilladams commented Oct 23, 2023

laflannery commented Oct 23, 2023 • edited Loading

jilladams commented Oct 23, 2023

laflannery commented Oct 24, 2023

jilladams commented Oct 11, 2023 •

edited by dsasser

Loading

jilladams commented Oct 20, 2023 •

edited

Loading

dsasser commented Oct 23, 2023 •

edited by jilladams

Loading

dsasser commented Oct 23, 2023 •

edited

Loading

laflannery commented Oct 23, 2023 •

edited

Loading

laflannery commented Oct 23, 2023 •

edited

Loading

laflannery commented Oct 23, 2023 •

edited

Loading