Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE: Update CLP help text and help image for 1:1 aspect ratio #15635

Closed
3 tasks done
wesrowe opened this issue Oct 10, 2023 · 11 comments
Closed
3 tasks done

BE: Update CLP help text and help image for 1:1 aspect ratio #15635

wesrowe opened this issue Oct 10, 2023 · 11 comments
Assignees
Labels
backend Campaign Landing Page Marketing campaign oriented, CMS-managed product owned by Public Websites team Drupal engineering CMS team practice area Public Websites Scrum team in the Sitewide crew sitewide

Comments

@wesrowe
Copy link
Contributor

wesrowe commented Oct 10, 2023

Description

CLP aspect ratio guidance is changing based on designs.
#15351 / CMS design in Figma

User story

AS A CLP Editor
I WANT help text and image to represent how the FE is (newly) going to render my page
SO THAT I can upload an appropriate image.

Acceptance criteria

  • Updated Hero image help text and help image at page top on CLP drupal UI, per designs
  • DO NOT MERGE PR
  • Move ticket to "Complete pending integration"
@wesrowe wesrowe added Needs refining Issue status Public Websites Scrum team in the Sitewide crew Drupal engineering CMS team practice area Campaign Landing Page Marketing campaign oriented, CMS-managed product owned by Public Websites team backend labels Oct 10, 2023
@jilladams jilladams removed the Needs refining Issue status label Oct 11, 2023
@chri5tia
Copy link
Contributor

For some reason I was not able to load the figma file and needed to request access. @thejordanwood, can you provide the help text and image here?

@thejordanwood
Copy link

@chri5tia You should have access to the Figma file now! I changed help text for a couple of the other fields too. Here's a list of the changes:

  1. Page title – Add a page title with sentence case capitalization. See capitalization guidelines
  2. Page introduction – Add a brief introduction that will also be used as a meta description in search results.
  3. Hero image – Provide an image to display in the hero. Your image will be displayed at a 1:1 aspect ratio. If your image does not already match that size, specify the square crop when prompted. If you do not add a hero image, the hero banner will display as a gradient background color.

This is an svg of the new image we should use.

hero-banner-guide-revised

@chri5tia
Copy link
Contributor

chri5tia commented Oct 13, 2023

@swirtSJW Do you know how to replace this image? In the UI config, the name of the image is entered but I'm not sure the best way to swap it out.

https://va-gov-cms.ddev.site/admin/structure/types/manage/campaign_landing_page/form-display

Screenshot 2023-10-13 at 11 07 46 AM

Looks like the image URL is https://va-gov-cms.ddev.site/modules/custom/va_gov_backend/images/hero-banner-guide.svg.

Update: Knowing the URL, I think I see that I can just commit it, disregard.

@jilladams
Copy link
Contributor

This work was completed in Sprint 95. It's now blocked from merging until change management is complete in #15806.

@jilladams jilladams assigned dsasser and jilladams and unassigned chri5tia Nov 8, 2023
@jilladams
Copy link
Contributor

Daniel or I will get PR merged when Change Mgmt is done.

@dsasser
Copy link
Contributor

dsasser commented Dec 1, 2023

Status Update 12/1/23

Work is complete but pending merge until change management is completed.

@jilladams
Copy link
Contributor

@dsasser this is the branch that will need to be merged in this sprint. when merged, please ping me, Randi, Jordan for awareness & we'll finish up.

@dsasser
Copy link
Contributor

dsasser commented Dec 6, 2023

@jilladams I'm working to get the branch mergable, but having some problems getting the checks and tests to pass. The changes in the PR are only Drupal config, unrelated to the failures as far as I can see at the moment. So it is taking me longer than I was hoping to get this merged in, FYI.

@dsasser
Copy link
Contributor

dsasser commented Dec 7, 2023

Status Update 12/7/23

Tugboat issues are preventing the last test from running, due to randomly returning 502s at times, which is apparently related to a recent finding that Tugboat is running out of memory.

See also https://dsva.slack.com/archives/CT4GZBM8F/p1701899552435089

@jilladams
Copy link
Contributor

Testing passed, PR merged.

@jilladams
Copy link
Contributor

Verified in prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Campaign Landing Page Marketing campaign oriented, CMS-managed product owned by Public Websites team Drupal engineering CMS team practice area Public Websites Scrum team in the Sitewide crew sitewide
Projects
None yet
Development

No branches or pull requests

5 participants