-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BE: Update CLP help text and help image for 1:1 aspect ratio #15635
Comments
For some reason I was not able to load the figma file and needed to request access. @thejordanwood, can you provide the help text and image here? |
@chri5tia You should have access to the Figma file now! I changed help text for a couple of the other fields too. Here's a list of the changes:
This is an svg of the new image we should use. |
@swirtSJW Do you know how to replace this image? In the UI config, the name of the image is entered but I'm not sure the best way to swap it out. https://va-gov-cms.ddev.site/admin/structure/types/manage/campaign_landing_page/form-display Looks like the image URL is https://va-gov-cms.ddev.site/modules/custom/va_gov_backend/images/hero-banner-guide.svg. Update: Knowing the URL, I think I see that I can just commit it, disregard. |
This work was completed in Sprint 95. It's now blocked from merging until change management is complete in #15806. |
Daniel or I will get PR merged when Change Mgmt is done. |
Status Update 12/1/23Work is complete but pending merge until change management is completed. |
@dsasser this is the branch that will need to be merged in this sprint. when merged, please ping me, Randi, Jordan for awareness & we'll finish up. |
@jilladams I'm working to get the branch mergable, but having some problems getting the checks and tests to pass. The changes in the PR are only Drupal config, unrelated to the failures as far as I can see at the moment. So it is taking me longer than I was hoping to get this merged in, FYI. |
Status Update 12/7/23Tugboat issues are preventing the last test from running, due to randomly returning 502s at times, which is apparently related to a recent finding that Tugboat is running out of memory. See also https://dsva.slack.com/archives/CT4GZBM8F/p1701899552435089 |
Testing passed, PR merged. |
Verified in prod. |
Description
CLP aspect ratio guidance is changing based on designs.
#15351 / CMS design in Figma
User story
AS A CLP Editor
I WANT help text and image to represent how the FE is (newly) going to render my page
SO THAT I can upload an appropriate image.
Acceptance criteria
The text was updated successfully, but these errors were encountered: