Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design: mobile app banner treatment for cross-browser use #15317

Closed
5 tasks
Tracked by #15742
jilladams opened this issue Sep 19, 2023 · 4 comments
Closed
5 tasks
Tracked by #15742

Design: mobile app banner treatment for cross-browser use #15317

jilladams opened this issue Sep 19, 2023 · 4 comments
Assignees
Labels
Design CMS team practice area Mobile app banners Public Websites owned product, promoting some health benefit pages. Public Websites Scrum team in the Sitewide crew sitewide UX

Comments

@jilladams
Copy link
Contributor

jilladams commented Sep 19, 2023

Description

#13481 added mobile app banners to Safari on IOS for specific pages.

We now want to expand those banners to appear on all other iOS and all Android browsers. This will likely replace the iOS Safari system banner.

There is a chance this design could become an experimental design in the DS, depending on what we mock up.

requirement

iOS default banner style should be mimicked for non iOS Safari browsers.

Acceptance criteria

  • Have mocked up banners that will display on mobile and tablet breakpoints using VA Design System
  • Banner styles are approved for Android apps to use default Android styles; iOS app to use default IOS styles.
  • A11y review
  • PM review
  • Collab Cycle Design Intent (this will need a new collab cycle kickoff)
@jilladams jilladams added Public Websites Scrum team in the Sitewide crew Design CMS team practice area UX Mobile app banners Public Websites owned product, promoting some health benefit pages. labels Sep 19, 2023
@jilladams jilladams changed the title Add mobile app banners for Android browsers Design: Add mobile app banners for Android browsers Sep 19, 2023
@wesrowe
Copy link
Contributor

wesrowe commented Sep 20, 2023

@jilladams, I think we might need a FE discovery ticket to research whether every browser has a default way to display app store links. From how Dave initially talked about this, I got the impression that we're essentially creating a new variation on banners, trying to either use the design system or adding to it.

Here's a discovery ticket.

@wesrowe wesrowe mentioned this issue Sep 23, 2023
30 tasks
@jilladams jilladams changed the title Design: Add mobile app banners for Android browsers Design: mobile app banner treatment for cross-browser use Oct 2, 2023
@jilladams
Copy link
Contributor Author

Have asked mobile app folks to confirm tablet support here, https://dsva.slack.com/archives/C018V2JCWRJ/p1696282519091189, but did find several old threads that reference Android tablets and the App store for VA app mentions iPad, so: for now have updated the ticket to assume tablet breakpoints will be included. FYI @thejordanwood

@jilladams
Copy link
Contributor Author

RyanT confirmed: mobile app works on tablet: https://dsva.slack.com/archives/C018V2JCWRJ/p1696282928205719?thread_ts=1696282519.091189&cid=C018V2JCWRJ

Have asked Dave C to confirm we should be including tablet breakpoint: https://dsva.slack.com/archives/C52CL1PKQ/p1696283186656859

@jilladams
Copy link
Contributor Author

Smartbanner.js native treatments for iOS and Android were signed off by PO and VA UX leads,
Amanda and Dave have both given their approval to use the default Android styling for the mobile banner in Slack thread with their approvals.

No additional artifacts required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design CMS team practice area Mobile app banners Public Websites owned product, promoting some health benefit pages. Public Websites Scrum team in the Sitewide crew sitewide UX
Projects
None yet
Development

No branches or pull requests

3 participants