Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revision log message on Vet Center Services are misleading #15125

Closed
3 of 12 tasks
Tracked by #18003
swirtSJW opened this issue Sep 6, 2023 · 7 comments
Closed
3 of 12 tasks
Tracked by #18003

Revision log message on Vet Center Services are misleading #15125

swirtSJW opened this issue Sep 6, 2023 · 7 comments
Assignees
@omahane
Labels
CY24-Q2 Calendar year Q2 2024 priority Defect Something isn't working (issue type) Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) sitewide Vet Center CMS managed product owned by Facilities team

Comments

@swirtSJW
Copy link
Contributor

swirtSJW commented Sep 6, 2023 •
edited by xiongjaneg
Loading

Describe the defect

When an editor edits a Vet Center Service, they have to do so using the Inline Entity Form on the Vet Center node. This does not provide a revision log message field so no new revision log message is saved. This makes it so that revision gets the same log message as the previous log message.
image

To Reproduce

Steps to reproduce the behavior:

  1. Go to a vet center'/node/3719/edit'
  2. Scroll down to the services, then click the edit button on the service.
  3. Make a change to the service.
  4. Save the Vet Center Facility node.
  5. Find the service you just edited in /admin/content?title=&type=vet_center_facility_health_servi&moderation_state=All&owner=All
  6. Click on the revisions tab
  7. Notice that the revision message for the change you just made is the same as the previous revision message.

AC / Expected behavior

  • A revision log message field to the IEF form as hidden.
  • A revision message is required when a Vet Center Service is saved (just like on the node itself)

Desktop (please complete the following information if relevant, or delete)

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Labels

(You can delete this section once it's complete)

  • Issue type (red) (defaults to "Defect")
  • CMS subsystem (green)
  • CMS practice area (blue)
  • CMS workstream (orange) (not needed for bug tickets)
  • CMS-supported product (black)

Team

Please check the team(s) that will do this work.

  • CMS Team
  • Public Websites
  • Facilities
  • User support
  • Accelerated Publishing
@swirtSJW swirtSJW added Defect Something isn't working (issue type) Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status Vet Center CMS managed product owned by Facilities team labels Sep 6, 2023
@swirtSJW
Copy link
Contributor Author

swirtSJW commented Sep 6, 2023

This is very similar to and has a similar solution set as #15124

IEF also causes bypass of "allow only one" validation"

@xiongjaneg xiongjaneg mentioned this issue Sep 7, 2023
Closed
3 tasks
@xiongjaneg xiongjaneg mentioned this issue Jan 30, 2024
Closed
2 tasks
@mmiddaugh
Copy link
Contributor

Related: Vet Center service editorial UX does not show national description #17177

@xiongjaneg xiongjaneg mentioned this issue Feb 26, 2024
Closed
@xiongjaneg xiongjaneg removed the Needs refining Issue status label Feb 28, 2024
@xiongjaneg
Copy link
Contributor

ticket for larger IEF issue was created #17374

@omahane omahane self-assigned this Feb 29, 2024
@omahane omahane mentioned this issue Feb 29, 2024
Closed
2 tasks
@xiongjaneg
Copy link
Contributor

Moving out of sprint 105 due to Christian's comment in #15124 about needing custom code

@jilladams jilladams mentioned this issue Apr 4, 2024
Closed
22 tasks
@davidmpickett davidmpickett added the CY24-Q2 Calendar year Q2 2024 priority label Apr 11, 2024
@jilladams jilladams mentioned this issue Apr 11, 2024
Open
1 task
@davidmpickett
Copy link
Contributor

This defect will be resolved once the IEF changes are implemented. Leaving this defect in backlog to confirm and close after #18003

@davidmpickett davidmpickett added the Blocked Issues that are blocked on factors other than blocking issues. label May 24, 2024
@davidmpickett davidmpickett mentioned this issue Jul 1, 2024
Closed
@Agile6MSkinner Agile6MSkinner mentioned this issue Jul 1, 2024
Closed
9 tasks
@Agile6MSkinner Agile6MSkinner removed the Blocked Issues that are blocked on factors other than blocking issues. label Jul 1, 2024
@jilladams
Copy link
Contributor

Can be validated / closed when #18003 ships

@davidmpickett
Copy link
Contributor

Validated on Staging
Screenshot 2024-08-19 at 2 01 36 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@omahane omahane

Labels
CY24-Q2 Calendar year Q2 2024 priority Defect Something isn't working (issue type) Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) sitewide Vet Center CMS managed product owned by Facilities team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@omahane @swirtSJW @davidmpickett @mmiddaugh @xiongjaneg @jilladams @Agile6MSkinner