Accessibility audit of updated VBA Facility content type

[xiongjaneg]

1. What is this request for?

Facility is a content type that will be updated to include VBA for the VBA Regional Office MVP

https://pr16076-0znhspa1mtvem1whd635hc16to4gcyg0.ci.cms.va.gov/node/4338/edit
or
https://prod.cms.va.gov/node/4338/edit (if the PR env has been removed)

Acceptance Criteria

• Code recommendations documented as ticket
• UX recommendations documented in Figma created in UX Review of updates to VBA Facility content type #14888

[xiongjaneg]

@swirtSJW Would you please add a comment here or in the description for how Laura can get to the content type to review?

[davidmpickett]

While this is not fully blocked by #14700, it might make sense to wait for that since it will be updating this content type

[laflannery]

Comments/Questions

1. Can we update the "Jump to edit" links?
   1. Remove Services: This link doesn't work and I also can't see where it would go so I don't think we need this.
   2. To be consistent, I would like to add links for:
      1. Banner alert (after Operating status)
      2. Prepare for your visit
      3. Spotlight content
2. Also, I'm confused on the Facility data section. The whole section has a dark gray background and a tool tip that indicates that I can't edit these fields. However, only some fields are actually read-only. The majority are fields I can actually type into and change the filled in data (though I didn't try to save the changed data because this was on Prod - maybe upon saving it would stop me?).
   1. I feel that this is a confusing experience - if this information actually cannot be edited, can we make this truly not editable?
3. The help text for the Facility Photo is not fabulous. This is also identical to Vet Center's right now. Is it within the scope of this work to update/change the VBA facility photo help text or is that outside the scope because it would change Vet Center content types as well? (To be clear I wouldn't necessarily want the help text different for VBA and Vet Center, I do want it changed for both.)

If any of the above are able to be changed - I can add these are separate tickets/comments in Figma depending

[davidmpickett]

2. Also, I'm confused on the Facility data section. The whole section has a dark gray background and a tool tip that indicates that I can't edit these fields. However, only some fields are actually read-only. The majority are fields I can actually type into and change the filled in data (though I didn't try to save the changed data because this was on Prod - maybe upon saving it would stop me?).
   I feel that this is a confusing experience - if this information actually cannot be edited, can we make this truly not editable?

Were you logged in as yourself when reviewing this? These fields are locked down for Content Editors & Reviewers & Publishers, but editable for Content Admins and True Admins. When I log in as [email protected], this whole section is grayed out.

That being said, we are breaking an existing pattern here since this data will truly be controlled in Drupal as opposed to migrated in from VAST, so we're going to need clear documentation on who/how this information gets updated. Future tickets to address some of these things:

• Restrict VBA RO editors from editing certain fields #15396
• CMS: Make Drupal source of Truth for VBA facility data #15366
• Determine VBA Facility change request process #15386

[davidmpickett]

3. The help text for the Facility Photo is not fabulous. This is also identical to Vet Center's right now. Is it within the scope of this work to update/change the VBA facility photo help text or is that outside the scope because it would change Vet Center content types as well? (To be clear I wouldn't necessarily want the help text different for VBA and Vet Center, I do want it changed for both.)

The following help text is within scope. Whatever we put here will be specific to this Content Type (though I agree that any edits here should also be reflected in other places this field is used)

<strong>Photo guidelines</strong> <br>
✓ Smart phone photos are ok <br>
✓ Use landscape orientation <br>
✓ Show the entrance side of the building <br>
✗ No people <br>
✗ No car license plates<br>

[laflannery]

@xiongjaneg Can you take a look at the comments above and let me know what's actionable/in scope from these comments and if there are any additional tickets I should make? To summarize the original comment:

1. Still pending (possibly needs an engineer?)
2. I was logging in as the wrong editor, I withdraw the question 😄
3. Still pending whether or not this is in scope and would require a separate ticket

[xiongjaneg]

@laflannery

1. Have you added these comments to the Figma file? If so, I can spin up tickets for updates to design and subsequent Drupal.
2. I think this it's best to go forward with your recommendations. Again, are these comments added to the Figma file? If so, I can include them in the design and subsequent Drupal ticket. I could also create a change management ticket for Vet Centers and VAMCs which will likely be KB updates.

Does this give you what you need to finish this ticket?

[laflannery]

@xiongjaneg The Figma isn't created yet, I have to wait until Jordan finishes her linked ticket. Once that is done, I will add these 2 comments, close this ticket and then ping you to make these follow ups, sound good?

[xiongjaneg]

@laflannery Perfect, thank you!

[thejordanwood]

@laflannery I've created the Figma doc for this now!

I’ve included some of the changes you brought up in this ticket, but am interested to hear if you have any thoughts on what the Facility photo help text should change to.

[laflannery]

Thanks @thejordanwood!

@xiongjaneg, Jordan ended up covering both my comments in her Figma, so we might not need any new tickets anymore from this specifically since any new tickets could just come out of the general UX ticket