Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facility phone audit report is missing some content types #14721

Closed
4 of 6 tasks
swirtSJW opened this issue Aug 9, 2023 · 5 comments
Closed
4 of 6 tasks

Facility phone audit report is missing some content types #14721

swirtSJW opened this issue Aug 9, 2023 · 5 comments
Labels
Defect Something isn't working (issue type) Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status sitewide

Comments

@swirtSJW
Copy link
Contributor

swirtSJW commented Aug 9, 2023

Describe the defect

Our phone audit report is missing the ability to select VAMC facilities and some vet centers, as well as NCA and VBA facilities. This report is essential for the VAMC mental health phone number cutover.

It is missing all facility types and has a bunch of content types in there that have no phones.

image

Hunch: Someone updated the filter on another View and mistakenly applied it to all displays rather than just the one they thought they were editing. It makes no sense otherwise, why we would have a report for phone numbers and then exclude the very things that have phone numbers.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://prod.cms.va.gov/admin/content/audit/phone-numbers
  2. Click on content type filter, notice there are no facilities in the list.

AC / Expected behavior

  • Facilities appear in the content type list.
  • Content types that have no phone numbers do not appear in the filter or in the View.
  • The view has a caption of "Phone number audit results"
    image
  • The view provides the ability to audit the VAMC mental health phone number.
  • Adjacent to the VAMC mental health phone number, add field mental-health-contact-phon
    • Should be sortable
@swirtSJW swirtSJW added Defect Something isn't working (issue type) Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status labels Aug 9, 2023
@jilladams
Copy link
Contributor

From scrum:

  • Audits are technically CMS owned but Facilities is the main consumer here
  • @xiongjaneg is syncing with Mike / Berni today so will close loop re: ownership

@swirtSJW
Copy link
Contributor Author

swirtSJW commented Aug 9, 2023

This was a bit of a mystery that took me a while to uncover. The original "proper" filter type_1 of content type is there, but someone hid it. And added a second filter 'type` that is the wrong one.
image
As near as I can tell, this breakage goes back to the originating ticket, but it seems odd that it has been broken that long and nobody noticed. There was a fair amount of chaos in the final days of that PR so it is possible something got broken.

Facilities team has not made updates to that file.

@swirtSJW
Copy link
Contributor Author

@jilladams @xiongjaneg This defect is making it hard to inspect much related to VAMC facility mental health phone numbers. It would be nice to get this into an upcoming sprint. (maybe related to creating a View to audit the mental health cutover)

@xiongjaneg xiongjaneg changed the title Facility phone audit report it missing some content types Facility phone audit report is missing some content types Oct 16, 2023
@xiongjaneg xiongjaneg added the Drupal engineering CMS team practice area label Oct 16, 2023
@swirtSJW
Copy link
Contributor Author

All but one of these AC's was resolved in #15769
The remaining AC has to go into the integration branch for mental health phone.

@swirtSJW
Copy link
Contributor Author

I am going to move this AC

Adjacent to the VAMC mental health phone number, add field mental-health-contact-phon
Should be sortable

Into #14214 and call this one done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Something isn't working (issue type) Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status sitewide
Projects
None yet
Development

No branches or pull requests

3 participants