Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to existing field field_mental_health_phone on VAMC facilities #14213

Closed
5 tasks done
kmariepat-cityfriends opened this issue Jun 29, 2023 · 24 comments
Closed
5 tasks done
Assignees
Labels
Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) sitewide VAMC CMS managed product owned by Facilities team

Comments

@kmariepat-cityfriends
Copy link

kmariepat-cityfriends commented Jun 29, 2023

Acceptance Criteria based on option 1

  • Make the existing field field_mental_health_phone on VAMC facilities editable by moving it out of the existing field set
  • I expect on node view to move the field to a matching grouping
  • I expect this field has help text (work with @thejordanwood and @mmiddaugh to determine copy)
  • Remove it from the migration (either keep the existing values)
  • I expect the content model documentation is updated

Option 1 - Make existing facility field editable

Solution

  • Make the existing field field_mental_health_phone on VAMC facilities editable.
  • Remove it from the migration (and either keep the existing values or blank them out)
  • Push that field to lighthouse with the status push.
  • Does this field need to be required?

Pros

  • Lowest lift
  • No FE change needed
  • No CMS content model change needed
  • Single point of failure, editor not entering a value.

Cons

  • No comprehensive fallback if there is no number specified at the facility level.
  • Data is not riding where it makes the most sense. Mental Health number is a number for a service, so making it a property of a facility seems misplaced.

Possible enhancements

  • Add a Clinical contact center field to each VAMC System that could be used as a fallback.
  • Make Mental Health facility service pull from this field on the facility rather than the main phone number.

Option 2 - Phone on Mental health service, fallback to existing field in Facility, fallback to new Clinical contact center number on system

Solution

  • Leverage "VA Health Connect phone" field to VAMC System content type since this number is a VISN level thing and that is as high up the existing chain as we can get it (or maybe this gets added to System Service?) .
  • Add "primary phone" field to VAMC Facility Service content type
  • When sending to lighthouse we send the Mental Health phone number based on this priority order
    • Primary phone from from Facility Mental Health Service.
    • Mental health number from the Facility
    • Clinical number from System (or system service)
  • This would definitely need changes to GraphQL queries and FE templates

Pros

  • Flexible for all variations of system and local overrides
  • Connects the number with the related service rather than off on its own at the Facility or System node.
  • Immediately extensible for any existing services (ie. Oncology hotline, Patient Advocates hotline ...) It would be there in case we needed it.
  • Redundant fall backs

Cons

  • Largest level of effort
  • Fallbacks are not transparent to editors (it resembles magic)
  • More points of failure due to complexity.
  • More difficult set of steps for editors to carry out this change.
@kmariepat-cityfriends kmariepat-cityfriends added Facilities Facilities products (VAMC, Vet Center, etc) VAMC CMS managed product owned by Facilities team Drupal engineering CMS team practice area labels Jun 29, 2023
@jilladams
Copy link
Contributor

The approach here to be determined by review with VHA DM. We need to get open questions answered, to confirm our assumptions.

@jilladams jilladams added the Blocked Issues that are blocked on factors other than blocking issues. label Jul 5, 2023
@davidmpickett
Copy link
Contributor

I updated the body of the card to include the full text of both options @swirtSJW wrote up in #13785. Based on conversations with VHA DM today, probably good to have both on the table

@xiongjaneg xiongjaneg removed the Blocked Issues that are blocked on factors other than blocking issues. label Sep 15, 2023
@mmiddaugh
Copy link
Contributor

mmiddaugh commented Sep 25, 2023

Collecting the latest thoughts:

We have the opportunity to leverage two fields

  • the facility-level mental health number (from the OMHSP/current source of truth)
  • the mental health service-level number(s) entered by editors

  • We need a way to connect this main facility mental health number with the service details displayed in the mental health service.
  • All facilities are not expected to have the mental health service associated with the location but are expected to display a mental health number. These locations will likely direct Veterans to call the system Medical Center's mental health number.
  • The facility-level mental health number can be assumed to be correct and can be used by default, but should be made editable.
  • We will want to consider what label to use when the system number appears so that Veterans understand they are calling a different medical center

@swirtSJW
Copy link
Contributor

@xiongjaneg I think this needs some post-finement because the AC's have not been updated since Kamari put them in on June 29 and I think are plans were not finalized at the time.

@xiongjaneg
Copy link
Contributor

@swirtSJW Do you have enough info to make those updates or do we need a product meeting?

@xiongjaneg
Copy link
Contributor

From 16th minutes:

  • Could put in integration branch until change management and Lighthouse are ready
  • Field where the number is automatically displayed is editable by editors
  • There is a field that is editable for editors to indicate where the custom phone number goes to (may be blank so that it doesn't display if an editor hasn't added text here)
  • What's the fallback number? The Main system phone number?
  • How to handle it in the service is outside the scope of this ticket.
  • Changing the label on the front end is out of scope of this ticket.

Michelle and Jane will talk to VHA DM about a default system number in addition to the editable field.

@swirtSJW
Copy link
Contributor

@thejordanwood and @mmiddaugh I need you guidance on what the text guidance for editors should see for this field.

It probably needs to be more than "Enter the phone number for mental health that gets answered by a human." but I imagine the language needs to be more official.

@mmiddaugh
Copy link
Contributor

I'd suggest something like this (assuming character limitation is not an issue)

Please enter the number which Veterans should call to access mental health at your facility. If your facility does not offer mental health services, please enter the most appropriate system number.

I don't think it needs to reference federal law.

@davidmpickett
Copy link
Contributor

  • Enter the direct phone number for the mental health department at your facility
  • Do not repeat the main phone number for your facility
  • Leave this blank if your facility does not have mental health services
  • This number will be displayed everywhere your facility appears across VA.gov (read more)

@swirtSJW
Copy link
Contributor

@davidmpickett @mmiddaugh Can we say "Leave this blank if your facility does not have mental health services" When this should be required and we are just not making it required to prevent them having to put in jibberish if they don't know?

I also have some concerns about saying don't repeat your main number. If the main number is the right place and they don't put it then the output on the FE will have no mental health number displayed and we fail the mandate.

@mmiddaugh
Copy link
Contributor

If the editor knows a number they'd like to direct Veterans to use, they should be able to enter it - I don't want to discourage that.
I like Dave's suggestion about source of truth and linking to more information.

Please enter the number which Veterans should call to access mental health at your facility. If your facility does not offer mental health services, please enter the most appropriate system number. This number will be displayed everywhere your facility appears across VA.gov (read more)

@xiongjaneg and I will get signoff from VHA DM early next week

@thejordanwood
Copy link

@mmiddaugh My suggestion would be to remove the word "please." Help text in the CMS is usually a bit more direct so removing that would make it more consistent. For accessibility purposes, the link should also say where this is linking off to.

Enter the number Veterans should call to access mental health services at your facility. If your facility doesn't offer these services, enter the most appropriate system number. This number will be displayed everywhere your facility appears across VA.gov. (View guidelines for editing VAMC facilities)

@mmiddaugh
Copy link
Contributor

awesome improvements, @thejordanwood - thank you!!

@swirtSJW
Copy link
Contributor

swirtSJW commented Oct 3, 2023

Here it is in place.

image

It links to the article and opens in a new tab following the example from other places in our system where help text links out.

@laflannery I looked in our codebase and we only have two indications when something opens in a new tab but I wasn't sure what we want as a standard.

Vet center: text in parentheses in the link
image
Covid Supplemental status (which is hidden right now) uses the text "opens in a new window" which I think is misleading anyway.
image

@BlakeOrgan @thejordanwood @laflannery
Given that Jordan's example is already in parentheses I am wondering if we need to do something different, or remove the parentheses around the link. I looked for quidance from existing patterns. Out of 41 links in help text, we have 20 that are in parentheses and 21 that are not.

A) (View guidelines for editing VAMC facilities (opens in a new tab))
B) View guidelines for editing VAMC facilities (opens in a new tab)
C) other

@laflannery
Copy link
Contributor

I'm assuming this is a KB article link? In that case, my vote is for B, I don't like double parentheses. If for some reason this is not linking to a KB article let me know

@thejordanwood
Copy link

thejordanwood commented Oct 3, 2023

My vote is also B. We can use this as an opportunity to start aligning with the VA content style guide, which doesn't put parentheses around links. I'll write them without parentheses going forward!

@BlakeOrgan
Copy link
Contributor

Agreed, I also think we should use B.

@swirtSJW
Copy link
Contributor

swirtSJW commented Oct 3, 2023

I updated the content model documentation
image

@xiongjaneg
Copy link
Contributor

Michelle emailed screenshot of field help text to VHA Digital Media on 10/4/23 for review. Awaiting a response. Next VHA Digital Media meeting is 10/17/23.

@swirtSJW
Copy link
Contributor

swirtSJW commented Oct 5, 2023

All of the of the other work on this will be PRs against the integration branch "integration-mental-health-phone" since it can not go directly to main.

@swirtSJW
Copy link
Contributor

swirtSJW commented Oct 5, 2023

I created this ticket to update the KB to address mental health numbers since we are linking to it in the help text.
edit: and closed it because it was a duplicate 😿

@jilladams
Copy link
Contributor

jilladams commented Oct 5, 2023

@swirtSJW @xiongjaneg integration branches are easy to lose track of, so made a ticket to track the branch merging to main: #15576. (In line with the Integration branches: ways of working doc we collabed on awhile ago.)

@swirtSJW
Copy link
Contributor

swirtSJW commented Oct 6, 2023

Updated the Integration branch pr to reference the tracking ticket Jill created ^^

@swirtSJW
Copy link
Contributor

swirtSJW commented Oct 6, 2023

The work for this ticket is complete and can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) sitewide VAMC CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

9 participants