Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters should be grouped using a <fieldset> and <legend> markup #12883

Closed
3 tasks
laflannery opened this issue Mar 8, 2023 · 3 comments
Closed
3 tasks

Filters should be grouped using a <fieldset> and <legend> markup #12883

laflannery opened this issue Mar 8, 2023 · 3 comments
Labels
accessibility Issues related to accessibility Blocked Issues that are blocked on factors other than blocking issues. Facilities Facilities products (VAMC, Vet Center, etc) Facility Locator product owned by Facilities team sitewide UX VA.gov frontend CMS team practice area

Comments

@laflannery
Copy link
Contributor

laflannery commented Mar 8, 2023

Description

Related field elements in the same form should be grouped together using a <fieldset> and <legend> markup. This allows sreen readers users to hear the context of each field as the go through the form.

For example, in the case of the search filter, if a legend were added of "Find a VA location", when they would hear "Service type, Find a VA location" when they tabbed to that particular select field.

Acceptance Criteria

  • <fieldset> wraps all form elements
  • Appropriate <legend> is added
  • Screen reader announces Legend for each form field
@laflannery laflannery added Facilities Facilities products (VAMC, Vet Center, etc) accessibility Issues related to accessibility labels Mar 8, 2023
@davidmpickett davidmpickett added the Facility Locator product owned by Facilities team label Mar 16, 2023
@laflannery
Copy link
Contributor Author

@thejordanwood can we also add this as annotations? Once we get the final filters confirmed I think this, as well as probably some other notes and directions would be helpful to ensure proper implementation

@kmariepat-cityfriends
Copy link

kmariepat-cityfriends commented May 25, 2023

Will hold on implementing until #11542 is complete OR in progress

@kmariepat-cityfriends kmariepat-cityfriends added the Blocked Issues that are blocked on factors other than blocking issues. label Jun 8, 2023
@jilladams jilladams added the VA.gov frontend CMS team practice area label Jun 23, 2023
@xiongjaneg xiongjaneg added the UX label Aug 21, 2023
@laflannery
Copy link
Contributor Author

Closing in favor of #14913

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issues related to accessibility Blocked Issues that are blocked on factors other than blocking issues. Facilities Facilities products (VAMC, Vet Center, etc) Facility Locator product owned by Facilities team sitewide UX VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

5 participants