Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate flipper facilities_ppms_suppress_all for removal #11589

Closed
3 tasks
dsinla opened this issue Nov 16, 2022 · 5 comments
Closed
3 tasks

Evaluate flipper facilities_ppms_suppress_all for removal #11589

dsinla opened this issue Nov 16, 2022 · 5 comments
Assignees
Labels
Facilities Facilities products (VAMC, Vet Center, etc) sitewide VA.gov frontend CMS team practice area

Comments

@dsinla
Copy link
Contributor

dsinla commented Nov 16, 2022

Description

Investigate facilities_ppms_suppress_all flipper for current use and eligibility for removal.

Refer to #10656

Tasks

Preview Give feedback
@dsinla dsinla added the Needs refining Issue status label Nov 16, 2022
@github-actions github-actions bot added the Facilities Facilities products (VAMC, Vet Center, etc) label Nov 16, 2022
@dsinla dsinla changed the title Establish criteria to remove flipper facilities_ppms_suppress_all FE: Establish criteria to remove flipper facilities_ppms_suppress_all Nov 16, 2022
@dsinla dsinla added the VA.gov frontend CMS team practice area label Nov 16, 2022
@Dottisea Dottisea removed the Needs refining Issue status label Feb 1, 2023
@davidconlon
Copy link
Contributor

This flipper exists so that if there are problems with the Provider Profile Management System (PPMS) we have the ability to disable all the front-end search interfaces that rely (either fully or partially) on data from PPMS.
At this time, the following Facility locator searches rely on data from PPMS:

  • Facility Type = Community providers (in VA’s network)
  • Facility Type = Community pharmacies (in VA’s network)
  • Facility Type = Urgent care + Service type = All in-network urgent care
  • Facility Type = Urgent care + Service type - In-network community urgent care
  • Facility Type = Emergency care + Service type = All in-network emergency care
  • Facility Type = Emergency care + Service type - In-network community emergency care

@Dottisea Dottisea added Public Websites Scrum team in the Sitewide crew and removed Facilities Facilities products (VAMC, Vet Center, etc) labels Feb 15, 2023
@FranECross FranECross added Facilities Facilities products (VAMC, Vet Center, etc) and removed Public Websites Scrum team in the Sitewide crew labels Feb 8, 2024
@Agile6MSkinner
Copy link

@jilladams @FranECross @mmiddaugh This flipper audit was done in late 2022. Would it even still be accurate? Are we realistically going to chase this work at any point?

@jilladams
Copy link
Contributor

I don't know how to answer. Does the Platform definitely want us to be removing unused Flippers due to performance overhead on the VA.gov site? Yep. Will we ever choose to prioritize this work? ...I'm not sure. Can we walk away from the tech debt just because we don't intend to prioritize it? ...dunno. If the Platform ever got worked up about Flipper performance again, and put pressure on teams to remove their old flippers: we would definitely have to prioritize this work and the other tickets like it. 🤷‍♀️

@Agile6MSkinner
Copy link

Makes sense. Backlog seems like a good place for it for now.

@Agile6MSkinner Agile6MSkinner changed the title FE: Establish criteria to remove flipper facilities_ppms_suppress_all Evaluate flipper facilities_ppms_suppress_all for removal Jul 11, 2024
@randimays randimays self-assigned this Dec 12, 2024
@jilladams
Copy link
Contributor

Will not remove. Will keep for long-term use. Closing as no op and #11591 will track updates on the flipper to document that in the flipper ui.

@jilladams jilladams closed this as not planned Won't fix, can't repro, duplicate, stale Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc) sitewide VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

8 participants