Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMS: Lovell Federal TRICARE Operating Status page issues #11557

Closed
2 of 9 tasks
Tracked by #11026
dsinla opened this issue Nov 11, 2022 · 11 comments
Closed
2 of 9 tasks
Tracked by #11026

CMS: Lovell Federal TRICARE Operating Status page issues #11557

dsinla opened this issue Nov 11, 2022 · 11 comments
Assignees
Labels
Facilities Facilities products (VAMC, Vet Center, etc) sitewide VA Lovell

Comments

@dsinla
Copy link
Contributor

dsinla commented Nov 11, 2022

Description

In the demo environment, on the Lovell Federal Tricare system page , in the Updates Block, the link to the Operating status points to the VA side when it should point to Lovell.

image

Originally documented in #11375

Also, right now the operating status page is assigned to the Lovell Federal health care section, so it should be duplicated to both sides. The VA page exists in the demo env: https://web-liqqgmzl7tsyfbwyulbkuborufuuttav.demo.cms.va.gov/lovell-federal-va-health-care/operating-status/
The TRICARE page does not: https://web-liqqgmzl7tsyfbwyulbkuborufuuttav.demo.cms.va.gov/lovell-federal-tricare-health-care/operating-status

Relates to #11848

Acceptance Criteria

  • Link to Operating Status in the Updates Block on the TRICARE page points to va.gov/lovell-federal-tricare-health-care/operating-status/
  • An Operating Status page is published for both TRICARE and VA

CMS Team

Please check the team(s) that will do this work.

  • Program
  • Platform CMS Team
  • Sitewide Crew
  • ⭐️ Sitewide CMS
  • ⭐️ Public Websites
  • ⭐️ Facilities
  • ⭐️ User support
@dsinla dsinla added the Needs refining Issue status label Nov 11, 2022
@github-actions github-actions bot added the Facilities Facilities products (VAMC, Vet Center, etc) label Nov 11, 2022
@dsinla dsinla mentioned this issue Nov 11, 2022
30 tasks
@dsinla
Copy link
Contributor Author

dsinla commented Nov 11, 2022

Poking around a bit further, looks like editors can enter an Operating Status and Link text in the System page, but it's blank in the demo env for Lovell TRICARE system. Looking at a few other systems in production, it looks like we explictly denote the Operating Status page.

image

Right now the operating status page is assigned to the Lovell Federal health care section, so it should be duplicated to both sides.

The VA page exists in the demo env: https://web-liqqgmzl7tsyfbwyulbkuborufuuttav.demo.cms.va.gov/lovell-federal-va-health-care/operating-status/
The TRICARE page does not: https://web-liqqgmzl7tsyfbwyulbkuborufuuttav.demo.cms.va.gov/lovell-federal-tricare-health-care/operating-status

Updating the ticket to address looking into why the page is not published to both VA and TRICARE.

@dsinla dsinla changed the title Link on Lovell Federal TRICARE health care to Operating Status should point to TRICARE, not VA CMS: Lovell Federal TRICARE Operating Status page issues Nov 11, 2022
@swirtSJW
Copy link
Contributor

Right now the operating status page is assigned to the Lovell Federal health care section, so it should be duplicated to both sides.

That is a mistake. Operating status pages reference specific facilities. Since the facilities are split between VA and TRICARE, there is no way we can have one page that spans both. The existing one should be set to section Lovell - VA and a new one needs to be created for Lovell - TRICARE.

@dsinla
Copy link
Contributor Author

dsinla commented Nov 17, 2022

Thanks @swirtSJW!

I set the existing page that was Lovell Federal health care to Lovell - VA
https://prod.cms.va.gov/lovell-federal-va-health-care/operating-status

I created a new VAMC System Operating Status. assigned it Lovell - TRICARE
https://prod.cms.va.gov/lovell-federal-tricare-health-care/operating-status

I published nothing, saved as DRAFT.

Upon creating of the new Oper Sys page, I could select the section
image

So I chose Lovell Federal TRICARE

I can't seem to edit the title on the (now previously) Lovell Federal health care page, which I changed to Lovell - VA,

Not sure about the Menu Link Title and Parent Link settings - I could use some education there - I just set the TRICARE page to what was set on the original Lovell Federal health care page
image

@dsinla
Copy link
Contributor Author

dsinla commented Nov 17, 2022

It was determined that this is an edge case specific to Operating Status pages.
I deleted the original page - which couldn't have its title updated.
I created a new page which displays the correct title:
Operating status | Lovell Federal VA health care
https://prod.cms.va.gov/lovell-federal-va-health-care/operating-status

@EWashb
Copy link
Contributor

EWashb commented Nov 21, 2022

Validate that this was fixed please @omahane

@omahane
Copy link
Contributor

omahane commented Dec 6, 2022

@maxx1128 @ryguyk
Do you know how this link is created? I am unclear why it would be set to "/node/36323/", given that this is a very Drupal-y URL.
Screen Shot 2022-12-06 at 12 36 34 PM

https://web-liqqgmzl7tsyfbwyulbkuborufuuttav.demo.cms.va.gov/lovell-federal-va-health-care/

@dawnpruitt
Copy link

@omahane fair to move this to In Progress? :)

@omahane
Copy link
Contributor

omahane commented Dec 12, 2022

@maxx1128 Do know what this js error is about on the VA and TRICARE Operating Status pages:

[Error] Warning: Encountered two children with the same key, 10. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.
ul
div
div
div
Footer@https://dev-va-gov-assets.s3-us-gov-west-1.amazonaws.com/generated/static-pages.entry.js:31550:20
Connect(Footer)@https://dev-va-gov-assets.s3-us-gov-west-1.amazonaws.com/generated/static-pages.entry.js:99644:68
Provider@https://dev-va-gov-assets.s3-us-gov-west-1.amazonaws.com/generated/static-pages.entry.js:99356:19
(anonymous function) (static-pages.entry.js:9438)
printWarning (static-pages.entry.js:69549)
error (static-pages.entry.js:69525)
warnOnInvalidKey (static-pages.entry.js:83102)
reconcileChildrenArray (static-pages.entry.js:83133)
reconcileChildren (static-pages.entry.js:86472)
updateHostComponent (static-pages.entry.js:87114)
beginWork$1 (static-pages.entry.js:93417)
performUnitOfWork (static-pages.entry.js:92256)
workLoopSync (static-pages.entry.js:92184)
renderRootSync (static-pages.entry.js:92147)
performSyncWorkOnRoot (static-pages.entry.js:91770)
scheduleUpdateOnFiber (static-pages.entry.js:91358)
updateContainer (static-pages.entry.js:94959)
(anonymous function) (static-pages.entry.js:95498)
unbatchedUpdates (static-pages.entry.js:91908)
legacyRenderSubtreeIntoContainer (static-pages.entry.js:95497)
startReactApp (static-pages.entry.js:32088)
startVAFooter (static-pages.entry.js:31947)
startSitewideComponents (static-pages.entry.js:27767)
(anonymous function) (static-pages.entry.js:115968)
(anonymous function) (static-pages.entry.js:7116)
withScope (static-pages.entry.js:8581)
(anonymous function) (static-pages.entry.js:115966)
(anonymous function) (static-pages.entry.js:116060)
Global Code (static-pages.entry.js:116061)

I'm seeing it in multiple browsers. It doesn't really block this ticket, but I don't know if it's something we've encountered before, either.

Screen Shot 2022-12-12 at 9 49 02 AM

@maxx1128
Copy link

@omahane I'm not sure, but my best guess is there are alert components with the same key and each one needs to be unique. It could be the key values are determined by the type of alert instead of a kind of randomly generated number.

@JayDarnell
Copy link
Contributor

JayDarnell commented Dec 13, 2022

@dawnpruitt @maxx1128 I could be mistaken but I don't think there is CMS dev work to be done here. This is either a front end issue or a problem with the CMS data in the Lovell demo environment being out of date. The URL currently being referenced for the Operating Status refers to the old Operating Status node for the Lovell umbrella system. That Lovell umbrella system is currently published in the demo environment and it shouldn't be. This referenced Operating Status page was deleted when the new ones for Lovell VA and Lovell TRICARE were created.

I think we need to rebuild this environment once department-of-veterans-affairs/content-build#1399 has been merged with a refresh of data from prod and then see if this link is still broken. If it is I believe it will require a front end fix. I'm cautiously optimistic that the issue will go away once we refresh the data.

@JayDarnell
Copy link
Contributor

This issue has been resolved. As suspected, once the front end was rebuilt with the appropriate CMS data these links are working fine.

  • The original Lovell Federal health care system is unpublished
  • The original Lovell Federal health care system operating status node was deleted
  • A new system operating status page was added for Lovell - VA and another for Lovell - TRICARE

Screenshot 2022-12-14 at 2 06 15 PM

Screenshot 2022-12-14 at 2 06 39 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc) sitewide VA Lovell
Projects
None yet
Development

No branches or pull requests

9 participants