Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio button - Intermittent issue with VoiceOver selecting a new radio #596

Open
3 tasks
TimRoe opened this issue Nov 22, 2024 · 0 comments
Open
3 tasks
Labels
design-system front-end Ticket requires front-end work

Comments

@TimRoe
Copy link
Contributor

TimRoe commented Nov 22, 2024

Description

It was noticed late working on #521 to create the Radio button component that there was an intermittent issue with VoiceOver in iOS (Android seemed to work fine). When you swipe onto one of the radio buttons that is unselected, it will read "[text/a11yLabel] unchecked" and then if you double tap to activate that radio it will sometimes read: "[text/a11yLabel] unchecked, [text/a11yLabel] checked" in succession while it should only read the "checked" part. This is confusing. My assumption is it's related to rerendering and it reading the "unchecked" associated with a rerender after the action then reading again once it rerenders to reflect that it has been checked. Given the state of what's selected should live outside the component, it was not immediately clear how best to resolve it.

Video of it working correctly (around 30-43 seconds):

RPReplay_Final1732303336.MP4

Video of the improper behavior:

RPReplay_Final1732303524.MP4

Acceptance Criteria

  • Update Radio button to not incorrectly read that a radio is unchecked immediately after checking it
  • Ping Brea that the Radio is ready for accessibility QA once merged

Accessibility Requirements

  • VoiceOver should not read that a radio is unchecked (then that it is checked) after you just checked it as it is confusing

Dev notes

  • A branch was created with the proof of concept in the app where the bugged behavior was observed
    • Due to an Expo update breaking iOS storybook at bug creation time it was not validated in the design system storybook
@TimRoe TimRoe added design-system front-end Ticket requires front-end work labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-system front-end Ticket requires front-end work
Projects
None yet
Development

No branches or pull requests

1 participant