From 6d8d289df9549f93a1efa1b24a233707736fac93 Mon Sep 17 00:00:00 2001 From: Tim R Date: Tue, 7 Nov 2023 15:56:30 -0600 Subject: [PATCH 1/4] Create pull_request_template.md --- .github/pull_request_template.md | 58 ++++++++++++++++++++++++++++++++ 1 file changed, 58 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 00000000..3ecfe5b9 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,58 @@ + + + +**[Ticket # ](https://github.com/department-of-veterans-affairs/va-mobile-app/issues/# )** + +## Description of Change + + +#### Testing Packages + + +### Screenshots/Video + + +## Testing + + +- [ ] Tested on iOS +- [ ] Tested on Android +- [ ] Tested on Web + +## PR Checklist +Code reviewer validation: +- General + - [ ] PR is connected to ticket(s) + - [ ] Acceptance criteria: + - All satisfied _or_ + - Documented reason for not being performed _or_ + - Split to separate ticket and ticket is linked by relevant AC(s) + - [ ] Above PR sections adequately filled out + - [ ] If any breaking changes, in accordance with the [pre-1.0.0 versioning guidelines](https://github.com/department-of-veterans-affairs/va-mobile-library#versioning-policy): a CU ticket has been created for the VA Mobile App detailing necessary adjustments with the package version that will be published by this ticket +- Code + - [ ] Tests are included if appropriate (or split to separate ticket) + - [ ] New functions have proper TSDoc annotations + +## Publish + +If changes warrant a new version [per the versioning guidelines](https://github.com/department-of-veterans-affairs/va-mobile-library#versioning-policy) and the PR is approved and ready to merge: +- [ ] Merge `main` into branch +- [ ] [Publish new version](https://github.com/department-of-veterans-affairs/va-mobile-library/actions/workflows/publish.yml) +- [ ] Merge branch to `main` From 2e156b39ca3249b76ad2aa69f212013256e6d58f Mon Sep 17 00:00:00 2001 From: Tim R Date: Wed, 8 Nov 2023 14:50:25 -0600 Subject: [PATCH 2/4] Update wording per PR suggestion --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 3ecfe5b9..9d5ae7b9 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -39,7 +39,7 @@ Consider highlighting: ## PR Checklist Code reviewer validation: - General - - [ ] PR is connected to ticket(s) + - [ ] PR is linked to ticket(s) - [ ] Acceptance criteria: - All satisfied _or_ - Documented reason for not being performed _or_ From f59998137a73855b3a367ad9b264c744c1612135 Mon Sep 17 00:00:00 2001 From: VA Automation Bot Date: Wed, 8 Nov 2023 21:01:03 +0000 Subject: [PATCH 3/4] Version bump: components-v0.1.1-alpha.5 --- packages/components/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/components/package.json b/packages/components/package.json index bf597633..af4cb4bc 100644 --- a/packages/components/package.json +++ b/packages/components/package.json @@ -1,6 +1,6 @@ { "name": "@department-of-veterans-affairs/mobile-component-library", - "version": "0.1.1-alpha.4", + "version": "0.1.1-alpha.5", "description": "VA Design System Mobile Component Library", "main": "src/index.tsx", "scripts": { From 2dcccdd90594131a786a78c4a317f8fa0ca7134b Mon Sep 17 00:00:00 2001 From: VA Automation Bot Date: Thu, 9 Nov 2023 18:13:04 +0000 Subject: [PATCH 4/4] Version bump: tokens-v0.1.1-alpha.0 --- packages/tokens/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/tokens/package.json b/packages/tokens/package.json index c3f6d11e..2f81b706 100644 --- a/packages/tokens/package.json +++ b/packages/tokens/package.json @@ -1,6 +1,6 @@ { "name": "@department-of-veterans-affairs/mobile-tokens", - "version": "0.1.0", + "version": "0.1.1-alpha.0", "description": "VA Design System Mobile Token Library", "main": "dist/js/tokens.js", "types": "dist/index.d.ts",