Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design System - Incorporate color Design Token into SegmentedControl component #6499

Closed
4 of 5 tasks
kellylein opened this issue Aug 14, 2023 · 4 comments
Closed
4 of 5 tasks
Assignees
Labels
front-end Ticket requires front-end work mobile-platform work associated with building & maintaining the VA Mobile Platform ux

Comments

@kellylein
Copy link
Contributor

kellylein commented Aug 14, 2023

One of our goals for Q3 is to utilize at least one VADS Design Token in our Design System. If the VADS Design Tokens are not published yet and ready for us to incorporate, we should incorporate a simple Design Token of our own as a POC. We were planning to use a color design token because they are simpler than typography.

AC:

  • Collect any previous discovery work on Design Tokens
  • Set up a Design Token on our side that we can utilize (since VADS isn't published yet)
  • Incorporate Design Token(s) into Figma (ux)
  • The colors of the SegmentedControl (button and text) when in Light Mode should be based on a Design Token
  • The colors of the SegmentedControl (button and text) when in Dark Mode should be based on a Design Token
@kellylein kellylein added front-end Ticket requires front-end work mobile-platform work associated with building & maintaining the VA Mobile Platform ux labels Aug 14, 2023
@kellylein kellylein added ux and removed ux labels Sep 7, 2023
@narin narin self-assigned this Sep 13, 2023
@narin
Copy link
Contributor

narin commented Sep 18, 2023

@narin
Copy link
Contributor

narin commented Sep 21, 2023

PR has been created the the code side of this ticket: department-of-veterans-affairs/va-mobile-library#18

Still need to determine the figma integration.

@bischoffa
Copy link
Contributor

Adding Sprint 81 as the ticket was not closed out in 80. Carryover work.

@narin
Copy link
Contributor

narin commented Sep 27, 2023

Spun off AC to incorporate token into Figma into #6860 since complexity seems higher than expected. The rest of the AC was completed Friday, Sep 22nd so I'm closing this out.

CC: @kellylein

@narin narin closed this as completed Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Ticket requires front-end work mobile-platform work associated with building & maintaining the VA Mobile Platform ux
Projects
None yet
Development

No branches or pull requests

3 participants