Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate new Loading Component into the App - Global #8936

Open
kellylein opened this issue Jun 27, 2024 · 6 comments · May be fixed by #10392
Open

Incorporate new Loading Component into the App - Global #8936

kellylein opened this issue Jun 27, 2024 · 6 comments · May be fixed by #10392
Assignees
@oddballdave
Labels
design-system-implementation front-end Ticket requires front-end work mobile-feature-support

Comments

@kellylein
Copy link
Contributor

kellylein commented Jun 27, 2024 •
edited by ajsarkar28
Loading

Monthly Update for Stakeholders

Date Progress & Key Accomplishments Issues/Risks/Blockers
9/9/24 Not started
9/17/24 Not started
10/1/24 Not started

Project Status Overview

Project Objective:

The Design System team has built the new Loading component as part of department-of-veterans-affairs/va-mobile-library#71. This Epic covers the Flagship Global team implementing that new component in the Global sections of the app. The Flagship team will give feedback on the process to the Design System team to help them improve the Design System.

Loading Component Notes

  • The Sync screen is currently using a white variant of the LoadingIndicator which will not be available with the new version
  • The app team has plans to redesign the login/sync screens with light/dark mode, so the LoadingIndicator should not be replaced on these screens until that work is complete
  • If the app team would like to avoid linting warnings for this screen, they should delay updating the linting package to the latest version until all of the LoadingComponents have been replaced with LoadingIndicator

Product Brief:

Monthly Update for Stakeholders

Date Progress & Key Accomplishments Issues/Risks/Blockers
MM/DD/YY
MM/DD/YY
MM/DD/YY
MM/DD/YY

Current Dependencies / Blockers

Blockers
Blocker Team / Owner Est to Resolution
Internal dependency ?
External dependency ?

Team Members

Contact List

VA:

  • Mobile OCTO Product Leads: Rachel Han or Ryan Thurlwell
  • VA OCTO Product Leads:
  • External Team 1 & Role:
  • External Team 1 & Role:

Ad Hoc:

  • Mobile Team: Global, Health and Benefits, Design System, QA, API
  • Mobile Team Lead:
  • FE Engineering:
  • BE Engineering:
  • Design:
  • Content
  • QA:
  • Mobile Teams that are involved: Global, Health and Benefits, Design System, QA, API
@kellylein kellylein added Epic front-end Ticket requires front-end work global Issues for the global team labels Jun 27, 2024
@TKDickson TKDickson removed their assignment Oct 9, 2024
@kellylein kellylein assigned jennb33 and unassigned ajsarkar28 Dec 6, 2024
@kellylein kellylein removed the global Issues for the global team label Dec 6, 2024
@jennb33
Copy link

jennb33 commented Dec 10, 2024

12/10/2024 - @ATeal let's assign this ticket in today's Stand-up

@jennb33 jennb33 removed their assignment Dec 12, 2024
@oddballdave oddballdave assigned oddballdave and unassigned ATeal Dec 17, 2024
@oddballdave oddballdave linked a pull request Dec 17, 2024 that will close this issue
chore/8936-UseDesignSystemLoadingComponent #10392
Open
8 tasks
@jennb33 jennb33 removed the Epic label Dec 17, 2024
@jennb33
Copy link

jennb33 commented Dec 19, 2024

12/19/2024 update: After several attempts to fix the detox issues with the Design System Loading component, Dave thinks there might be a fix that resolves the problematic animations that cause a lot of e2e test to fail. This requires a small code change/patch to the Loading component. Testing this now.
@oddballdave we determined during the stand-up that we should push this patch fix to Don for his review.

@jennb33
Copy link

jennb33 commented Jan 2, 2025

1/2/2025 - Moved ticket to Sprint 8 to be completed.

@jennb33
Copy link

jennb33 commented Jan 2, 2025

1/2/2025 - @oddballdave can you please detail the work that is still outstanding in this ticket? TIA

@oddballdave
Copy link
Contributor

1/2/2025 - @oddballdave can you please detail the work that is still outstanding in this ticket? TIA

The work is complete. PR created. Just waiting for engineering and QA review.

@jennb33
Copy link

jennb33 commented Jan 2, 2025

1/2/2025 - ticket is with @DonMcCaugheyUSDS for QA/PR approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oddballdave oddballdave

Labels
design-system-implementation front-end Ticket requires front-end work mobile-feature-support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore/8936-UseDesignSystemLoadingComponent department-of-veterans-affairs/va-mobile-app
6 participants
@ATeal @ajsarkar28 @kellylein @jennb33 @TKDickson @oddballdave