Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise API routes docstrings to be useful for OpenAPI docs #74

Open
4 tasks
cris-oddball opened this issue Nov 15, 2024 · 0 comments
Open
4 tasks

Revise API routes docstrings to be useful for OpenAPI docs #74

cris-oddball opened this issue Nov 15, 2024 · 0 comments
Labels
Feature Notify Board trigger PM Reviewed Reviewed by Product Manager QA Reviewed Reviewed by Quality Assurance QA Issue requires QA collaboration

Comments

@cris-oddball
Copy link
Contributor

User Story - Business Need

API documentation is the contract between VANotify and our clients as to how to utilize API routes. Currently, the docstrings which autogenerate the API spec are more method based, listing the route's arguments, what is raised and what is returned. This is not useful for API documentation. This ticket aims to update all API route docstrings such that they become useful for developers to integrate with our API.

  • Ticket is understood, and QA has been contacted (if the ticket has a QA label).

User Story(ies)

As a VANotify developer
I want to revise the docstrings for API routes
So that our API documentation is useful.

As a developer integrating with our API
I want a clearly understandable document
So that I understand how to build out an integration.

Additional Info and Resources

  • Medium post on How to document an API for Python FastAPI (downloaded PDF of this is available on request).

  • Current view of OpenAPI POST route in ENP
    Image

  • What a better OpenAPI route would look like (from the above blog post)
    Image

Acceptance Criteria

  • The ENP OpenAPI spec no longer informs as to the internal workings of each route but clearly describes the usage of each API route.
  • A style guide is posted to the Team Repo and added to its glossary for API docstrings.

QA Considerations

  • Review final document for clarity.

Potential Dependencies

Out of Scope

We only want to change the API docstrings, not internal method/class/test docstrings

@cris-oddball cris-oddball added Notify Board trigger QA Issue requires QA collaboration QA Reviewed Reviewed by Quality Assurance labels Nov 15, 2024
@kbelikova-oddball kbelikova-oddball added PM Reviewed Reviewed by Product Manager Feature labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Notify Board trigger PM Reviewed Reviewed by Product Manager QA Reviewed Reviewed by Quality Assurance QA Issue requires QA collaboration
Projects
None yet
Development

No branches or pull requests

2 participants