Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notification-api Database Connection #114

Open
7 tasks
k-macmillan opened this issue Dec 30, 2024 · 0 comments
Open
7 tasks

notification-api Database Connection #114

k-macmillan opened this issue Dec 30, 2024 · 0 comments
Labels
Dev Reviewed Reviewed by Tech Lead Notify Board trigger PM Reviewed Reviewed by Product Manager QA Reviewed Reviewed by Quality Assurance QA Issue requires QA collaboration

Comments

@k-macmillan
Copy link
Member

User Story - Business Need

Add read and write database context managers to connect to the notification-api. Add admin GET route for notifications.

We want va-enp-api to be capable of connecting to the notification-api database until it is fully independent. We also need to validate the connection.

  • Ticket is understood, and QA has been contacted (if the ticket has a QA label).

User Story(ies)

As a VA Notify dev
I want to connect to the notification-api
So that I can perform tasks such as validation

Additional Info and Resources

  • Read and write contexts already exist. We should probably reuse them by allowing a parameter and the default parameter would be va-enp-api's engines.
  • Admin GET notification route would not require service.

Acceptance Criteria

  • SOLID principles
  • A read and write context manager have been implemented (or existing repurposed)
  • Read context manager can be used to GET a notification from the notification-api
  • GET notification does not require a service id
  • URL does not require a service id e.g. GET /legacy/v2/notifications
  • This work is added to the sprint review slide deck (key win bullet point and demo slide)

QA Considerations

Touching base with the dev regarding the GET route.

Potential Dependencies

The service has to be running in order to connect to the database.
The admin JWT needs to be in place.

Out of Scope

Testing the ability to write to the database.
For v3 we'll use the iss field of the JWT to identify the service id or lack thereof.

@k-macmillan k-macmillan added Dev Reviewed Reviewed by Tech Lead Notify Board trigger QA Issue requires QA collaboration labels Dec 30, 2024
@cris-oddball cris-oddball added the QA Reviewed Reviewed by Quality Assurance label Jan 3, 2025
@cris-oddball cris-oddball mentioned this issue Jan 3, 2025
7 tasks
@kbelikova-oddball kbelikova-oddball added PM Reviewed Reviewed by Product Manager Ready for Refinement labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev Reviewed Reviewed by Tech Lead Notify Board trigger PM Reviewed Reviewed by Product Manager QA Reviewed Reviewed by Quality Assurance QA Issue requires QA collaboration
Projects
None yet
Development

No branches or pull requests

4 participants