From 11032f3120b1009830154db2fe8e25df8edf9aa0 Mon Sep 17 00:00:00 2001
From: Chris Kim <42885441+chriskim2311@users.noreply.github.com>
Date: Wed, 4 Dec 2024 10:40:36 -0800
Subject: [PATCH] VACMS-18521 Remove tech debt detail-page.html (#2370)

---
 .../components/navigation-links-list.html     | 71 -------------------
 src/site/includes/detail-page.html            | 49 -------------
 src/site/layouts/page-breadcrumbs.html        |  3 -
 3 files changed, 123 deletions(-)
 delete mode 100644 src/site/components/navigation-links-list.html
 delete mode 100644 src/site/includes/detail-page.html

diff --git a/src/site/components/navigation-links-list.html b/src/site/components/navigation-links-list.html
deleted file mode 100644
index 7599d4e062..0000000000
--- a/src/site/components/navigation-links-list.html
+++ /dev/null
@@ -1,71 +0,0 @@
-{% comment %}
-=====================
-Links List
-=====================
-
-Used for:
-- lists of links to content within a particular channel or section.
-- lists of Related Links when the `isRelated` property is set in the
-include tag, e.g.:
-{% include "src/site/components/navigation-links-list.html" with isRelated = true %}
-
-NOTE: Can also pass majorlinks or relatedlinks in as a variable on the include
-tag, e.g.:
-
-  {% include "src/site/components/navigation-links-list.html" with majorlinks = anothergroupofmajorlinks %}
-
-In this example, `anothergroupofmajorlinks` is a group of links that uses the
-same YAML structure as `majorlinks`, but with a different group name. Pass the
-different group name as the value for the `majorlinks` variable of the include.
-
-See https://help.shopify.com/themes/liquid/tags/theme-tags#include
-{% endcomment %}
-
-{% if isRelated == true %}
-{% assign linklist = relatedlinks %}
-{% else %}
-{% assign linklist = majorlinks %}
-{% endif %}
-
-<div class="row">
-  <div class="usa-content columns">
-    <aside class="va-nav-linkslist {% if isRelated %}va-nav-linkslist--related{% endif %}">
-    {% for group in linklist %}
-
-      {% comment %}
-        Only add <section> if there are heading titles.
-      {% endcomment %}
-
-      {% if group.heading != empty %}
-        <section>
-          <h3 class="va-nav-linkslist-heading">{{ group.heading }}</h3>
-      {% endif %}
-
-      {% if group.links.length > 0 %}
-        <ul class="va-nav-linkslist-list">
-        {% for link in group.links %}
-          {% if link.url != empty %}
-            <li>
-              <a href="{{link.url}}" onClick="recordEvent({ event: 'nav-linkslist' });">
-              {% if link.title != empty %}
-                <h4 class="va-nav-linkslist-title">{{ link.title }}</h4>
-              {% endif %}
-
-              {% if link.description != empty %}
-                <p class="va-nav-linkslist-description">{{ link.description }}</p>
-              {% endif %}
-              </a>
-            </li>
-          {% endif %}
-        {% endfor %}
-        </ul>
-      {% endif %}
-
-    {% endfor %}
-
-    {% if link.heading != empty %}
-      </section>
-    {% endif %}
-    </aside>
-  </div>
-</div>
diff --git a/src/site/includes/detail-page.html b/src/site/includes/detail-page.html
deleted file mode 100644
index e9890bce03..0000000000
--- a/src/site/includes/detail-page.html
+++ /dev/null
@@ -1,49 +0,0 @@
-{% comment %}
-
-=====================
-Detail Page with side navigation, next + previous links,
-and related links.
-=====================
-
-- Use for interior detail pages that do not have child content. (i.e va.gov/education/about-gi-bill-benefits/)
-
-{% endcomment %}
-
-<main class="va-l-detail-page">
-  {% if hidesidenav == empty %}
-  {% include "src/site/components/navigation-sidebar-trigger.html" with menuId = "va-detailpage-sidebar" %}
-  {% endif %}
-  <div class="vads-l-grid-container desktop-lg:vads-u-padding-x--0">
-    <div class="vads-l-row vads-u-margin-x--neg2p5">
-      {% if hidesidenav == empty %}
-      <div class="vads-l-col--12 vads-u-padding-x--2p5 medium-screen:vads-l-col--4 large-screen:vads-l-col--3">
-        {% include "src/site/components/navigation-sidebar.html" with newGrid = true %}
-      </div>
-      {% endif %}
-      <div class="vads-l-col--12 vads-u-padding-x--2p5 medium-screen:vads-l-col--8 large-screen:vads-l-col--9">
-        {% if no_article_bottom_padding %}
-        <article class="usa-content new-grid vads-u-padding-bottom--0">
-          <h1>{{ heading }}</h1>
-          {{ contents }}
-        </article>
-        {% else %}
-        <article class="usa-content new-grid">
-          <h1>{{ heading }}</h1>
-          {{ contents }}
-        </article>
-        {% endif %}
-
-        {% if majorlinks != empty %}
-        {% include "src/site/components/navigation-links-list.html" %}
-        {% endif %}
-
-        {% if relatedlinks != empty %}
-        {% include "src/site/components/navigation-links-list.html" with isRelated = true %}
-        {% endif %}
-
-        <!-- Last updated & feedback button -->
-        {% include "src/site/includes/above-footer-elements.drupal.liquid" %}
-      </div>
-    </div>
-  </div>
-</main>
\ No newline at end of file
diff --git a/src/site/layouts/page-breadcrumbs.html b/src/site/layouts/page-breadcrumbs.html
index 513267e91c..c94e6c9b14 100755
--- a/src/site/layouts/page-breadcrumbs.html
+++ b/src/site/layouts/page-breadcrumbs.html
@@ -16,9 +16,6 @@
   {% endif %}
 
   {% case template %}
-    {% when 'detail-page' %}
-      {% include "src/site/includes/detail-page.html" %}
-
     {% when 'education-sco' %}
       {% include "src/site/includes/education-sco.html" %}
   {% else %}