Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README is outdated #142

Open
scarf005 opened this issue Dec 16, 2024 · 3 comments
Open

README is outdated #142

scarf005 opened this issue Dec 16, 2024 · 3 comments
Assignees

Comments

@scarf005
Copy link

scarf005 commented Dec 16, 2024

Usage

deno 2 stabilized ffi, --unstable is not needed anymore: denoland/deno#25213

Benchmarks

on README:

image

however recent benchmark show that deno is the slowest:

image

@DjDeveloperr
Copy link
Member

Thanks for reporting, I'll update the README.

As for benchmarks, where is the source? I believe that must be a different benchmark that shows those results. Will look into updating charts for the current one too against newest versions.

@DjDeveloperr DjDeveloperr self-assigned this Dec 18, 2024
@scarf005
Copy link
Author

scarf005 commented Dec 18, 2024

As for benchmarks, where is the source? I believe that must be a different benchmark that shows those results.

it's literally from the https://github.com/denodrivers/sqlite3 README:

sqlite3/README.md

Lines 41 to 42 in c078d61

[Benchmark](./bench) based on
[just-js/02-sqlite](https://just-js.github.io/benchmarks/02-sqlite.html)

@DjDeveloperr
Copy link
Member

DjDeveloperr commented Dec 19, 2024

Ah, I missed that - the README points there as the source of benchmarks - those do not use this library - but we use the same code to benchmark it. Deno benchmark there uses the slower, WASM based SQLite library. See https://github.com/just-js/benchmarks/blob/main/02-sqlite/bench-deno.js

The key word is "based on".

This library is not included in benchmarks on that website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants