Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Use docker-based redis for tests #325

Open
ClaudiuCeia opened this issue Aug 1, 2022 · 0 comments
Open

Suggestion: Use docker-based redis for tests #325

ClaudiuCeia opened this issue Aug 1, 2022 · 0 comments

Comments

@ClaudiuCeia
Copy link
Contributor

Hi team,

I sent a small PR today and I was confused about not being able to run tests. I eventually figured out that the tests expect docker to be installed locally. I understand why the tests need to be integration tests, but I think it would help if tests could run against a docker-based redis instance (or cluster) to avoid installing and messing with the local install.

Maybe a docker-compose.yml that you just need to docker compose up -d before running the tests, based on the official redis images?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant