Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seems to only add one song when I use it trying to add a track from SoundCloud #1

Open
itsbrex opened this issue Mar 5, 2016 · 2 comments

Comments

@itsbrex
Copy link

itsbrex commented Mar 5, 2016

Songs chosen (at random) were these three:

  1. https://soundcloud.com/badjokes/duko-the-ripper-badjokes-remix
  2. https://soundcloud.com/bengrunnell/kuo-climax-long-time-ben-grunnell-remix
  3. https://soundcloud.com/bengrunnell/ben-grunnell-cosmology-original-mix

All 3 tries resulted in this track (not one of the ones above) being added to the playlists I selected:

@dennislysenko
Copy link
Owner

Hm, sounds like there's an undefined value somewhere. I did write the server in javascript so it's a definite possibility on the server side. It's also possible that the soundcloud site was updated and broke the song detection code (I'm not really maintaining this repo as it stands because I don't use spotify anymore). Does it work on other sites, say Youtube for example?

If it turns out to be that soundcloud updated and broke the song detection code, you may be able to find a replacement at https://github.com/david-sabata/web-scrobbler/tree/master/connectors/v2. If you end up finding a fix I'll be overjoyed to accept a pull request. Otherwise I will try and get to it when I have time, but I can't promise anything.

@itsbrex
Copy link
Author

itsbrex commented Mar 7, 2016

Sounds good. I will try to go on a couple other sites and report back. I will also check out that repo and let you know. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@dennislysenko @itsbrex and others