Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Universal Action and keyboard shortcuts as triggers #12

Open
muffix opened this issue Oct 23, 2022 · 2 comments
Open

Add Universal Action and keyboard shortcuts as triggers #12

muffix opened this issue Oct 23, 2022 · 2 comments

Comments

@muffix
Copy link
Contributor

muffix commented Oct 23, 2022

I added hotkeys and an universal action as input triggers for this workflow in my personal setup. I'd like to contribute it back, but the workflow's info.plist is not part of this repo. I'd like to add it to the repo and update it.

This would also allow automating the release process with a GitHub action.

Happy to submit PRs for both.
muffix added a commit to muffix/alfred-dict.cc-workflow that referenced this issue Oct 23, 2022
@muffix
Add universal action, hotkeys as triggers
6b721f3 
Adds keyboard hotkeys to trigger the workflow for the current selection
or the clipboard contents. Also adds a universal action trigger if the
selection is text (as opposed to file or URL).

The keyboard shortcuts are not part of the `info.plist` and even if they
were, they would be ignored when imported.

Relates to: dennis-tra#12
@muffix muffix mentioned this issue Oct 23, 2022
Merged
muffix added a commit to muffix/alfred-dict.cc-workflow that referenced this issue Oct 23, 2022
@muffix
Add a GitHub action for release
f3080f0 
This adds a GitHub action to build and release the workflow whenever a
tag is pushed that looks like a semver tag.

When a release with a corresponding tag is created through the GitHub
interface, this action runs. It builds and packages the workflow and
then adds the workflow to the existing GitHub release.

If a tag is pushed, but no GitHub release exists, it creates a new one.
The title is going to be the pushed tag and the body the commit message
of the commit the tag points to.

Relates to: dennis-tra#12
@muffix muffix mentioned this issue Oct 23, 2022
Closed
muffix added a commit to muffix/alfred-dict.cc-workflow that referenced this issue Oct 23, 2022
@muffix
Add a GitHub action for release
9b47b5b 
This adds a GitHub action to build and release the workflow whenever a
tag is pushed that looks like a semver tag.

When a release with a corresponding tag is created through the GitHub
interface, this action runs. It builds and packages the workflow and
then adds the workflow to the existing GitHub release.

If a tag is pushed, but no GitHub release exists, it creates a new one.
The title is going to be the pushed tag and the body the commit message
of the commit the tag points to.

Relates to: dennis-tra#12
@muffix muffix mentioned this issue Oct 23, 2022
Closed
@muffix
Copy link
Contributor Author

muffix commented Oct 23, 2022

Added PRs for both, while the latter depends on the former. Would you mind having a look @dennis-tra?

@dennis-tra
Copy link
Owner

Thanks so much @muffix! Just a heads up, I'm currently travelling and will only have time to check back with the PRs end of next week :/

dennis-tra pushed a commit that referenced this issue Oct 3, 2023
@muffix @dennis-tra
Add universal action, hotkeys as triggers
d336da7 
Adds keyboard hotkeys to trigger the workflow for the current selection
or the clipboard contents. Also adds a universal action trigger if the
selection is text (as opposed to file or URL).

The keyboard shortcuts are not part of the `info.plist` and even if they
were, they would be ignored when imported.

Relates to: #12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dennis-tra @muffix