Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow live update of slides menu #37

Open
rajgoel opened this issue Jul 14, 2017 · 5 comments
Open

Allow live update of slides menu #37

rajgoel opened this issue Jul 14, 2017 · 5 comments

Comments

@rajgoel
Copy link
Contributor

rajgoel commented Jul 14, 2017

It would be great if it would be possible to re-initialize the slide menu, if slides are added dynamically. Would it be possible to add a respective API (or is this already possible and I haven't figured out how to do so)?

@denehyg
Copy link
Owner

denehyg commented Jul 31, 2017

This is currently not available, it's not a use case I considered. To do properly will most probably require some refactoring of the code. I'll add it to the list.

@rajgoel
Copy link
Contributor Author

rajgoel commented Aug 1, 2017

Thanks for your reply. My particular use case is to load a markdown file from within the presentation (see https://rajgoel.github.io/reveal.js-demos/markdown-viewer.html). Thus, in fact I would only need to be able to delay the initialization of the menu creation until the file is loaded. Do you think this is easier?

@denehyg
Copy link
Owner

denehyg commented Aug 14, 2017

I've implemented the interim functionality of delaying initialisation in the delay-init branch (af24352). It would be appreciated if you could test this against your use case and let me know if it suits.

@rajgoel
Copy link
Contributor Author

rajgoel commented Aug 15, 2017

Works just as expected for me 🥇

Thanks a lot!

@denehyg
Copy link
Owner

denehyg commented Aug 19, 2017

Thanks. I've merged this into the dev branch. I'll leave this issue open as it would be worthwhile to fully implement the re-initialisation of the menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants