Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable bcc_self=1 every time we detect a sync message in our inbox #6433

Open
link2xt opened this issue Jan 13, 2025 · 4 comments · May be fixed by #6434
Open

Enable bcc_self=1 every time we detect a sync message in our inbox #6433

link2xt opened this issue Jan 13, 2025 · 4 comments · May be fixed by #6434
Assignees

Comments

@link2xt
Copy link
Collaborator

link2xt commented Jan 13, 2025

This is an actionable replacement issue for #6432

If we detect a sync message, even if one of the devices has switched to bcc_self=0 due to some unknown bug, we will automatically recover back to bcc_self=1.

bcc_self now essentially means "multi-device setup" and is used to decide whether to send sync messages in should_send_sync_msgs.

I would not do the same on any outgoing message because it is possible that the server copies own messages to Sent like Gmail does and maybe changes Message-ID like outlook does, so seeing a message from self, especially unencrypted, is not a very clear indication that we have a multi-device setup, but sync message is unlikely to produce false positives.

@gerryfrancis
Copy link
Contributor

I would not do the same on any outgoing message because it is possible that the server copies own messages to Sent like Gmail does and maybe changes Message-ID like outlook does

To be clear: This change applies to Chatmail accounts only, right?

@link2xt
Copy link
Collaborator Author

link2xt commented Jan 13, 2025

@gerryfrancis Not only. For non-chatmail accounts we also want this, because there user can disable bcc-self manually and we want to reenable it back if user has a second device which keeps sending sync messages as it is a mistake to disable bcc-self in multi-device setup.

@gerryfrancis
Copy link
Contributor

gerryfrancis commented Jan 13, 2025

@link2xt Understood, but please log the timestamp somewhere in the database when the user enabled/disabled bcc_self so we can ignore older sync messages from another Delta Chat client to avoid an (unwanted) overwrite of this setting. (Some users forget about their second device, especially when it has become damaged/lost.)

@link2xt
Copy link
Collaborator Author

link2xt commented Jan 13, 2025

Normally Delta Chat does not load old messages unless you restore a backup. But if you restore a backup, storing timestamp in the database will not help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants