Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise a Python exception if a gRPC message surpasses 32mb #389

Open
jeffngo opened this issue Jul 28, 2021 · 0 comments
Open

Raise a Python exception if a gRPC message surpasses 32mb #389

jeffngo opened this issue Jul 28, 2021 · 0 comments
Assignees

Comments

@jeffngo
Copy link
Contributor

jeffngo commented Jul 28, 2021

Plugin developers could potentially need to write a file onto a remote host for certain operations. gRPC sets a default limit of 4MB per message, but that default limit was tuned to 32mb in a recent submission. The problem is that whenever the 32mb limit is reached, the error message that is returned from gRPC/netty is quite cryptic (broken pipe in debug logs).

We want to find a more direct way to communicate that the limit was reached. One idea that was proposed in code review was that we could add a check on the SDK side to check whether or not the 32mb limit will be reached. The problem with this solution is that we do not have a way of querying the Delphix Engine for the tunable without exposing a callback that does that for us.

This feature request is asking for a way to gracefully fail whenever a message/metadata limit is reached from the SDK side.

@jeffngo jeffngo self-assigned this Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant