Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dvp build does not error out if "type" field is omitted from plugin schema definitions #323

Open
ravi-cm opened this issue Jan 26, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@ravi-cm
Copy link
Contributor

ravi-cm commented Jan 26, 2021

** Expected Behavior**
dvp build should error out that type is a required field and missing from the schema definition.

** Actual Behavior**
dvp build allows omission of type and upload succeeds. This can cause runtime issues.

Steps To Reproduce the Problem

  1. Create a plugin schema file with repository definition missing "type":"object" line.
  2. Run "dvp build" - which succeeds.
  3. Run dvp upload and upload the artifact to an engine which will cause an exception on the engine.
@ravi-cm ravi-cm self-assigned this Jan 26, 2021
@ravi-cm ravi-cm added the bug Something isn't working label Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

1 participant