Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .gitignore during wp.org plugin build #17

Open
kliqks opened this issue Jun 27, 2018 · 3 comments
Open

Remove .gitignore during wp.org plugin build #17

kliqks opened this issue Jun 27, 2018 · 3 comments

Comments

@kliqks
Copy link

kliqks commented Jun 27, 2018

I don't know when it happened, but it appears that /vendor is added to the gitignore. At least in my deployment, this makes the entire vendor folder not added to the commit and therefore, I imagine the whole plugin will fail to work. As a matter of fact, the vendor folder appears to be missing from this repo as well.

@polevaultweb
Copy link
Member

@kliqks I don't commit the vendor directory here, but package it with the build that does to the WordPress repo. I clarified that here with install instructions: https://github.com/deliciousbrains/wp-migrate-db-anonymization#installation

@kliqks
Copy link
Author

kliqks commented Jun 27, 2018

@polevaultweb That's cool, but the gitignore with the /vendor line will keep people that use the plugin from the WordPress plugin store from committing that folder in their own repo's. Seriously, I might be the only one doing it this way, but it's how I need to do it for my AWS High Availability sites. For git purposes, maybe this needs to be included in your .git/info/exclude file instead of using the gitignore. Thank you though, I love this plugin.

@polevaultweb
Copy link
Member

@kliqks good point, but that is an edge case. I'll look at removing the .gitignore for the build. Any reason you aren't using Composer to manage the plugins, that way they stay out of your git repos?
https://deliciousbrains.com/using-composer-manage-wordpress-themes-plugins/

@polevaultweb polevaultweb reopened this Jun 27, 2018
@polevaultweb polevaultweb changed the title .gitignore /vendor Remove .gitignore during wp.org plugin build Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants