Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Lord1112 in the README #40

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Lord1112
Copy link
Collaborator

Issue #26 resolved
Changes: I added Sergi Ocaña as a junior contributor

@Lord1112 Lord1112 requested a review from IperM September 14, 2023 09:51
@Lord1112 Lord1112 self-assigned this Sep 14, 2023
@Lord1112 Lord1112 linked an issue Sep 14, 2023 that may be closed by this pull request
@Lord1112 Lord1112 changed the title docs: added my username docs: added Lord1112 in the README Sep 14, 2023
Copy link
Collaborator

@IperM IperM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats!!

You PR it's ready to merge, when you feel confident you can do a merge!

@IperM
Copy link
Collaborator

IperM commented Sep 14, 2023

Before merging apply one change on the title and place it as add

@Lord1112 Lord1112 changed the title docs: added Lord1112 in the README docs: add Lord1112 in the README Sep 14, 2023
@IperM
Copy link
Collaborator

IperM commented Sep 14, 2023

If you want to have it perfect you must edit the description and place more like This PR closes #... where the three dots are your issue number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introducing Myself (Lord1112)
2 participants