Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UI for displaying overlapping locked and unlocking funds in governance #108

Open
goldsteinsveta opened this issue Sep 7, 2024 · 1 comment
Labels
Priority: 🟡 P2 Added to issues and PRs relating to a medium severity bugs. Type: 🫶 Enhancement Added to issues and PRs when a change includes improvements or optimizations.

Comments

@goldsteinsveta
Copy link
Collaborator

Screenshot 2024-09-07 at 19 38 35
@goldsteinsveta goldsteinsveta changed the title Highlight locked balances instead of number of locks in "Unlocking" Highlight locked funds instead of number of locks in "Unlocking" Sep 7, 2024
@Tbaut
Copy link
Contributor

Tbaut commented Sep 8, 2024

This is a good idea, but it's tricky, because the locked funds are overlapping so say I'm unlocking:

  • 10 DOTs on track 1
  • 5 DOTs on track 0

-> I'm actually unlocking max 10 DOTs here BUT, while you may think as a user that you'll have 10 DOTs free when those locks are done.. well it's not true because if you're still voting or delegating with 10 DOTs or more on other tracks/refs.. well you'll effectively not unlock anything. Just the track 1 and 0 are free (while unlocking) to be voted or delegated on. If that makes any sense.

So while I wouldn't show the DOTs on the unlocking card, because it's so confusing and complex to display, it may be cool to show how much is locked in governance overall. And this is basically the max from what you're delegating or voting on any ref/track without the conviction.

So say I'm

  • voting on ref 123 with 1 DOTs x6
  • voting on ref 456 with 2 DOTs x1
  • delegating on track 1 with 1 DOTs x6
  • delegating on track 2 with 2 DOTs x1

The total locked is 2 DOTs. I'm not even talking about lock time here, but if you unlock all at the same time, you'll get 2 DOTs locked until the x1 conviction is elapsed, then the remaining 1 DOT locked until the x6 is elapsed. Not extremely complex, but not straight-forward either, or easy to explain in a couple words

@goldsteinsveta goldsteinsveta changed the title Highlight locked funds instead of number of locks in "Unlocking" Improve UI for displaying overlapping locked and unlocking funds in governance Sep 9, 2024
@wirednkod wirednkod added Priority: 🟡 P2 Added to issues and PRs relating to a medium severity bugs. Type: 🫶 Enhancement Added to issues and PRs when a change includes improvements or optimizations. labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 🟡 P2 Added to issues and PRs relating to a medium severity bugs. Type: 🫶 Enhancement Added to issues and PRs when a change includes improvements or optimizations.
Projects
None yet
Development

No branches or pull requests

3 participants