Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate monitoring for GitLab #116

Closed
zachariahmiller opened this issue May 1, 2024 · 0 comments · Fixed by #117
Closed

Validate monitoring for GitLab #116

zachariahmiller opened this issue May 1, 2024 · 0 comments · Fixed by #117
Assignees

Comments

@zachariahmiller
Copy link
Contributor

Describe what should be investigated or refactored

We need to validate that monitoring is setup correctly for GitLab when on top of uds-core.

Links to any relevant code

defenseunicorns/uds-core#17

Additional context

This should just using the monitoring stack from uds-core

@zachariahmiller zachariahmiller self-assigned this May 1, 2024
@zachariahmiller zachariahmiller linked a pull request May 1, 2024 that will close this issue
5 tasks
zachariahmiller added a commit that referenced this issue May 3, 2024
## Description
Enabled service and pod monitors in gitlab. For running on k3d-slim-dev
in ci/local we dont have to update anything as the gitlab chart checks
for the monitoring capabilities presence to deploy the service monitor
templates.

Depends on uds-core
[0.21.0](https://github.com/defenseunicorns/uds-core/releases/tag/v0.21.0).

Note: the pepr capability to mutate the service monitors but not pod
monitors so we will need to request that feature or PR uds-core to add
it. Adding the config for the pod monitor does no break anything.

As this wont get tested in CI in this repo (we should consider the
"on-release" test that will exist soon to deploy a full cluster) I will
provide visual proof in the comments. This requires no changes to the
end user to enable.

## Related Issue

Fixes #
[116](#116)
Relates to #

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/uds-package-gitlab/blob/main/CONTRIBUTING.md#developer-workflow)
followed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant