Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 17.2: Compatibility with 3.7 #51

Merged
merged 5 commits into from
Apr 29, 2024
Merged

Release 17.2: Compatibility with 3.7 #51

merged 5 commits into from
Apr 29, 2024

Conversation

lldelisle
Copy link
Collaborator

See #50

@lldelisle lldelisle closed this Apr 11, 2024
@lldelisle lldelisle reopened this Apr 11, 2024
@lldelisle lldelisle changed the title Release 17.2: Fix importlib metadata Release 17.2: Compatibility with 3.7 Apr 11, 2024
@lldelisle
Copy link
Collaborator Author

@bgruening Ready for review.

@lldelisle
Copy link
Collaborator Author

Hi @bgruening ,
In the last version I put a dependency that impose python >= 3.8 but I think it is better to keep the compatibility with 3.7.
This release, put back the compatibility. Would you mind to have a look or just tell me it is ok to release without double-check?

@bgruening
Copy link
Member

Ok, but please keep in mind that Python 3.7 is already EOL https://devguide.python.org/versions/

@lldelisle
Copy link
Collaborator Author

Yes I know... I will drop in the next release.

@lldelisle lldelisle merged commit a8336dd into deeptools:master Apr 29, 2024
8 checks passed
@lldelisle lldelisle deleted the fix_importlib_metadata branch April 29, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgruening bgruening bgruening approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lldelisle @bgruening